|
Hannes Reinecke |
e38592 |
From: Mikulas Patocka <mpatocka@redhat.com>
|
|
Hannes Reinecke |
e38592 |
Date: Sat, 23 Jan 2021 09:19:56 -0500
|
|
Hannes Reinecke |
e38592 |
Subject: [PATCH] dm writecache: fix performance degradation in ssd mode
|
|
Hannes Reinecke |
e38592 |
Git-commit: cb728484a7710c202f02b96aa0962ce9b07aa5c2
|
|
Hannes Reinecke |
e38592 |
Patch-mainline: v5.12-rc1
|
|
Hannes Reinecke |
e38592 |
References: git-fixes
|
|
Hannes Reinecke |
e38592 |
|
|
Hannes Reinecke |
e38592 |
Fix a thinko in ssd_commit_superblock. region.count is in sectors, not
|
|
Hannes Reinecke |
e38592 |
bytes. This bug doesn't corrupt data, but it causes performance
|
|
Hannes Reinecke |
e38592 |
degradation.
|
|
Hannes Reinecke |
e38592 |
|
|
Hannes Reinecke |
e38592 |
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
|
|
Hannes Reinecke |
e38592 |
Fixes: dc8a01ae1dbd ("dm writecache: optimize superblock write")
|
|
Hannes Reinecke |
e38592 |
Cc: stable@vger.kernel.org # v5.7+
|
|
Hannes Reinecke |
e38592 |
Reported-by: J. Bruce Fields <bfields@redhat.com>
|
|
Hannes Reinecke |
e38592 |
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
|
|
Hannes Reinecke |
e38592 |
Acked-by: Hannes Reinecke <hare@suse.com>
|
|
Hannes Reinecke |
e38592 |
---
|
|
Hannes Reinecke |
e38592 |
drivers/md/dm-writecache.c | 2 +-
|
|
Hannes Reinecke |
e38592 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
Hannes Reinecke |
e38592 |
|
|
Hannes Reinecke |
e38592 |
diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
|
|
Hannes Reinecke |
e38592 |
index d5223a0e5cc5..1769653c3d6b 100644
|
|
Hannes Reinecke |
e38592 |
--- a/drivers/md/dm-writecache.c
|
|
Hannes Reinecke |
e38592 |
+++ b/drivers/md/dm-writecache.c
|
|
Hannes Reinecke |
e38592 |
@@ -523,7 +523,7 @@ static void ssd_commit_superblock(struct dm_writecache *wc)
|
|
Hannes Reinecke |
e38592 |
|
|
Hannes Reinecke |
e38592 |
region.bdev = wc->ssd_dev->bdev;
|
|
Hannes Reinecke |
e38592 |
region.sector = 0;
|
|
Hannes Reinecke |
e38592 |
- region.count = PAGE_SIZE;
|
|
Hannes Reinecke |
e38592 |
+ region.count = PAGE_SIZE >> SECTOR_SHIFT;
|
|
Hannes Reinecke |
e38592 |
|
|
Hannes Reinecke |
e38592 |
if (unlikely(region.sector + region.count > wc->metadata_sectors))
|
|
Hannes Reinecke |
e38592 |
region.count = wc->metadata_sectors - region.sector;
|
|
Hannes Reinecke |
e38592 |
--
|
|
Hannes Reinecke |
e38592 |
2.29.2
|
|
Hannes Reinecke |
e38592 |
|