From 5edc24ac876a928f36f407a0fcdb33b94a3a210f Mon Sep 17 00:00:00 2001

From: Tudor Ambarus <tudor.ambarus@microchip.com>

Date: Wed, 15 Dec 2021 13:01:06 +0200

Subject: [PATCH] dmaengine: at_xdmac: Print debug message after realeasing the lock

Git-commit: 5edc24ac876a928f36f407a0fcdb33b94a3a210f

Patch-mainline: v5.17-rc1

References: git-fixes

It is desirable to do the prints without the lock held if possible, so

move the print after the lock is released.

Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Link: https://lore.kernel.org/r/20211215110115.191749-4-tudor.ambarus@microchip.com

Signed-off-by: Vinod Koul <vkoul@kernel.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/dma/at_xdmac.c | 6 ++++--

 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c

index c3d3e1270236..7d3560acedbb 100644

--- a/drivers/dma/at_xdmac.c

+++ b/drivers/dma/at_xdmac.c

@@ -473,10 +473,12 @@ static dma_cookie_t at_xdmac_tx_submit(struct dma_async_tx_descriptor *tx)

 	spin_lock_irqsave(&atchan->lock, irqflags);

 	cookie = dma_cookie_assign(tx);

-	dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n",

-		 __func__, atchan, desc);

 	list_add_tail(&desc->xfer_node, &atchan->xfers_list);

 	spin_unlock_irqrestore(&atchan->lock, irqflags);

+

+	dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n",

+		 __func__, atchan, desc);

+

 	return cookie;

 }

-- 

2.31.1