From b9b6752e5fd333fb88023cb5de4c1e6c0ce9d4e2 Mon Sep 17 00:00:00 2001

From: Yuan Can <yuancan@huawei.com>

Date: Wed, 7 Dec 2022 08:54:10 +0000

Subject: [PATCH 1/3] drivers: net: qlcnic: Fix potential memory leak in

 qlcnic_sriov_init()

Patch-mainline: v6.2-rc1

Git-commit: 01de1123322e4fe1bbd0fcdf0982511b55519c03

References: jsc#PED-1523

If vp alloc failed in qlcnic_sriov_init(), all previously allocated vp

needs to be freed.

Fixes: f197a7aa6288 ("qlcnic: VF-PF communication channel implementation")

Signed-off-by: Yuan Can <yuancan@huawei.com>

Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Denis Kirjanov <denis.kirjanov@suse.com>

---

 drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 2 ++

 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

index 9282321c2e7f..f9dd50152b1e 100644

--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

@@ -221,6 +221,8 @@ int qlcnic_sriov_init(struct qlcnic_adapter *adapter, int num_vfs)

 	return 0;

 qlcnic_destroy_async_wq:

+	while (i--)

+		kfree(sriov->vf_info[i].vp);

 	destroy_workqueue(bc->bc_async_wq);

 qlcnic_destroy_trans_wq:

-- 

2.16.4