Takashi Iwai 8e3ebb
From c4aa8dff6091cc9536aeb255e544b0b4ba29faf4 Mon Sep 17 00:00:00 2001
Takashi Iwai 8e3ebb
From: Madhav Chauhan <madhav.chauhan@amd.com>
Takashi Iwai 8e3ebb
Date: Fri, 16 Oct 2020 18:03:07 +0530
Takashi Iwai 8e3ebb
Subject: [PATCH] drm/amdgpu: don't map BO in reserved region
Takashi Iwai 8e3ebb
Mime-version: 1.0
Takashi Iwai 8e3ebb
Content-type: text/plain; charset=UTF-8
Takashi Iwai 8e3ebb
Content-transfer-encoding: 8bit
Takashi Iwai 8e3ebb
Git-commit: c4aa8dff6091cc9536aeb255e544b0b4ba29faf4
Takashi Iwai 8e3ebb
Patch-mainline: v5.10-rc2
Takashi Iwai 8e3ebb
References: git-fixes
Takashi Iwai 8e3ebb
Takashi Iwai 8e3ebb
2MB area is reserved at top inside VM.
Takashi Iwai 8e3ebb
Takashi Iwai 8e3ebb
Suggested-by: Christian König <christian.koenig@amd.com>
Takashi Iwai 8e3ebb
Signed-off-by: Madhav Chauhan <madhav.chauhan@amd.com>
Takashi Iwai 8e3ebb
Reviewed-by: Christian König <christian.koenig@amd.com>
Takashi Iwai 8e3ebb
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Takashi Iwai 8e3ebb
Cc: stable@vger.kernel.org
Takashi Iwai 8e3ebb
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 8e3ebb
Takashi Iwai 8e3ebb
---
Takashi Iwai 8e3ebb
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c |   10 ++++++++++
Takashi Iwai 8e3ebb
 1 file changed, 10 insertions(+)
Takashi Iwai 8e3ebb
Takashi Iwai 8e3ebb
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
Takashi Iwai 8e3ebb
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
Takashi Iwai 8e3ebb
@@ -563,6 +563,7 @@ int amdgpu_gem_va_ioctl(struct drm_devic
Takashi Iwai 8e3ebb
 	struct ww_acquire_ctx ticket;
Takashi Iwai 8e3ebb
 	struct list_head list, duplicates;
Takashi Iwai 8e3ebb
 	uint64_t va_flags;
Takashi Iwai 8e3ebb
+	uint64_t vm_size;
Takashi Iwai 8e3ebb
 	int r = 0;
Takashi Iwai 8e3ebb
 
Takashi Iwai 8e3ebb
 	if (args->va_address < AMDGPU_VA_RESERVED_SIZE) {
Takashi Iwai 8e3ebb
@@ -583,6 +584,15 @@ int amdgpu_gem_va_ioctl(struct drm_devic
Takashi Iwai 8e3ebb
 
Takashi Iwai 8e3ebb
 	args->va_address &= AMDGPU_VA_HOLE_MASK;
Takashi Iwai 8e3ebb
 
Takashi Iwai 8e3ebb
+	vm_size = adev->vm_manager.max_pfn * AMDGPU_GPU_PAGE_SIZE;
Takashi Iwai 8e3ebb
+	vm_size -= AMDGPU_VA_RESERVED_SIZE;
Takashi Iwai 8e3ebb
+	if (args->va_address + args->map_size > vm_size) {
Takashi Iwai 8e3ebb
+		dev_dbg(&dev->pdev->dev,
Takashi Iwai 8e3ebb
+			"va_address 0x%llx is in top reserved area 0x%llx\n",
Takashi Iwai 8e3ebb
+			args->va_address + args->map_size, vm_size);
Takashi Iwai 8e3ebb
+		return -EINVAL;
Takashi Iwai 8e3ebb
+	}
Takashi Iwai 8e3ebb
+
Takashi Iwai 8e3ebb
 	if ((args->flags & ~valid_flags) && (args->flags & ~prt_flags)) {
Takashi Iwai 8e3ebb
 		dev_dbg(&dev->pdev->dev, "invalid flags combination 0x%08X\n",
Takashi Iwai 8e3ebb
 			args->flags);