Takashi Iwai 38a39d
From 9ce0af3e9573fb84c4c807183d13ea2a68271e4b Mon Sep 17 00:00:00 2001
Takashi Iwai 38a39d
From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Takashi Iwai 38a39d
Date: Tue, 27 Oct 2020 13:14:42 +0900
Takashi Iwai 38a39d
Subject: [PATCH] drm/vc4: drv: Add error handding for bind
Takashi Iwai 38a39d
Git-commit: 9ce0af3e9573fb84c4c807183d13ea2a68271e4b
Takashi Iwai 38a39d
Patch-mainline: v5.10-rc2
Takashi Iwai 38a39d
References: git-fixes
Takashi Iwai 38a39d
Takashi Iwai 38a39d
There is a problem that if vc4_drm bind fails, a memory leak occurs on
Takashi Iwai 38a39d
the drm_property_create side. Add error handding for drm_mode_config.
Takashi Iwai 38a39d
Takashi Iwai 38a39d
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Takashi Iwai 38a39d
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Takashi Iwai 38a39d
Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com
Takashi Iwai 38a39d
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 38a39d
Takashi Iwai 38a39d
---
Takashi Iwai 38a39d
 drivers/gpu/drm/vc4/vc4_drv.c | 1 +
Takashi Iwai 38a39d
 1 file changed, 1 insertion(+)
Takashi Iwai 38a39d
Takashi Iwai 38a39d
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
Takashi Iwai 38a39d
index f1a5fd5dab6f..a17aa1db11b6 100644
Takashi Iwai 38a39d
--- a/drivers/gpu/drm/vc4/vc4_drv.c
Takashi Iwai 38a39d
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
Takashi Iwai 38a39d
@@ -314,6 +314,7 @@ static int vc4_drm_bind(struct device *dev)
Takashi Iwai 38a39d
 	component_unbind_all(dev, drm);
Takashi Iwai 38a39d
 gem_destroy:
Takashi Iwai 38a39d
 	vc4_gem_destroy(drm);
Takashi Iwai 38a39d
+	drm_mode_config_cleanup(drm);
Takashi Iwai 38a39d
 	vc4_bo_cache_destroy(drm);
Takashi Iwai 38a39d
 dev_put:
Takashi Iwai 38a39d
 	drm_dev_put(drm);
Takashi Iwai 38a39d
-- 
Takashi Iwai 38a39d
2.16.4
Takashi Iwai 38a39d