From: Stephen Hemminger <stephen@networkplumber.org>

Date: Fri, 29 Dec 2017 10:02:52 -0800

Subject: ethtool: do not print warning for applications using legacy API

Git-commit: 71891e2dab6b55a870f8f7735e44a2963860b5c6

Patch-mainline: v4.15-rc8

References: networking-stable-18_01_12

In kernel log ths message appears on every boot:

 "warning: `NetworkChangeNo' uses legacy ethtool link settings API,

  link modes are only partially reported"

When ethtool link settings API changed, it started complaining about

usages of old API. Ironically, the original patch was from google but

the application using the legacy API is chrome.

Linux ABI is fixed as much as possible. The kernel must not break it

and should not complain about applications using legacy API's.

This patch just removes the warning since using legacy API's

in Linux is perfectly acceptable.

Fixes: 3f1ac7a700d0 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API")

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Signed-off-by: David Decotigny <decot@googlers.com>

Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 net/core/ethtool.c |   15 ++-------------

 1 file changed, 2 insertions(+), 13 deletions(-)

--- a/net/core/ethtool.c

+++ b/net/core/ethtool.c

@@ -754,15 +754,6 @@ static int ethtool_set_link_ksettings(st

 	return dev->ethtool_ops->set_link_ksettings(dev, &link_ksettings);

 }

-static void

-warn_incomplete_ethtool_legacy_settings_conversion(const char *details)

-{

-	char name[sizeof(current->comm)];

-

-	pr_info_once("warning: `%s' uses legacy ethtool link settings API, %s\n",

-		     get_task_comm(name, current), details);

-}

-

 /* Query device for its ethtool_cmd settings.

  *

  * Backward compatibility note: for compatibility with legacy ethtool,

@@ -789,10 +780,8 @@ static int ethtool_get_settings(struct n

 							   &link_ksettings);

 		if (err < 0)

 			return err;

-		if (!convert_link_ksettings_to_legacy_settings(&cmd,

-							       &link_ksettings))

-			warn_incomplete_ethtool_legacy_settings_conversion(

-				"link modes are only partially reported");

+		convert_link_ksettings_to_legacy_settings(&cmd,

+							  &link_ksettings);

 		/* send a sensible cmd tag back to user */

 		cmd.cmd = ETHTOOL_GSET;