From 6e5d5791730b55a1f987e1db84b078b91eb49e99 Mon Sep 17 00:00:00 2001

From: Yang Li <yang.lee@linux.alibaba.com>

Date: Tue, 23 Feb 2021 16:35:58 +0800

Subject: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT

Git-commit: 6e5d5791730b55a1f987e1db84b078b91eb49e99

Patch-mainline: v5.12-rc3

References: git-fixes

fixed the following coccicheck:

./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no

primary handler requested without IRQF_ONESHOT

Make sure threaded IRQs without a primary handler are always request

with IRQF_ONESHOT

Reported-by: Abaci Robot <abaci@linux.alibaba.com>

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/gpio/gpiolib-acpi.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c

index e37a57d0a2f0..86efa2d9bf7f 100644

--- a/drivers/gpio/gpiolib-acpi.c

+++ b/drivers/gpio/gpiolib-acpi.c

@@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio,

 	int ret, value;

 	ret = request_threaded_irq(event->irq, NULL, event->handler,

-				   event->irqflags, "ACPI:Event", event);

+				   event->irqflags | IRQF_ONESHOT, "ACPI:Event", event);

 	if (ret) {

 		dev_err(acpi_gpio->chip->parent,

 			"Failed to setup interrupt handler for %d\n",

-- 

2.26.2