|
Takashi Iwai |
b3a873 |
From 13462ba1815db5a96891293a9cfaa2451f7bd623 Mon Sep 17 00:00:00 2001
|
|
Takashi Iwai |
b3a873 |
From: Tom Rix <trix@redhat.com>
|
|
Takashi Iwai |
b3a873 |
Date: Sat, 8 Jan 2022 07:09:48 -0800
|
|
Takashi Iwai |
b3a873 |
Subject: [PATCH] i3c: master: dw: check return of dw_i3c_master_get_free_pos()
|
|
Takashi Iwai |
b3a873 |
Git-commit: 13462ba1815db5a96891293a9cfaa2451f7bd623
|
|
Takashi Iwai |
b3a873 |
Patch-mainline: v5.17-rc1
|
|
Takashi Iwai |
b3a873 |
References: git-fixes
|
|
Takashi Iwai |
b3a873 |
|
|
Takashi Iwai |
b3a873 |
Clang static analysis reports this problem
|
|
Takashi Iwai |
b3a873 |
dw-i3c-master.c:799:9: warning: The result of the left shift is
|
|
Takashi Iwai |
b3a873 |
undefined because the left operand is negative
|
|
Takashi Iwai |
b3a873 |
COMMAND_PORT_DEV_INDEX(pos) |
|
|
Takashi Iwai |
b3a873 |
^~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Takashi Iwai |
b3a873 |
|
|
Takashi Iwai |
b3a873 |
pos can be negative because dw_i3c_master_get_free_pos() can return an
|
|
Takashi Iwai |
b3a873 |
error. So check for an error.
|
|
Takashi Iwai |
b3a873 |
|
|
Takashi Iwai |
b3a873 |
Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
|
|
Takashi Iwai |
b3a873 |
Signed-off-by: Tom Rix <trix@redhat.com>
|
|
Takashi Iwai |
b3a873 |
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
|
|
Takashi Iwai |
b3a873 |
Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com
|
|
Takashi Iwai |
b3a873 |
Acked-by: Takashi Iwai <tiwai@suse.de>
|
|
Takashi Iwai |
b3a873 |
|
|
Takashi Iwai |
b3a873 |
---
|
|
Takashi Iwai |
b3a873 |
drivers/i3c/master/dw-i3c-master.c | 4 ++++
|
|
Takashi Iwai |
b3a873 |
1 file changed, 4 insertions(+)
|
|
Takashi Iwai |
b3a873 |
|
|
Takashi Iwai |
b3a873 |
diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
|
|
Takashi Iwai |
b3a873 |
index 03a368da51b9..51a8608203de 100644
|
|
Takashi Iwai |
b3a873 |
--- a/drivers/i3c/master/dw-i3c-master.c
|
|
Takashi Iwai |
b3a873 |
+++ b/drivers/i3c/master/dw-i3c-master.c
|
|
Takashi Iwai |
b3a873 |
@@ -793,6 +793,10 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
|
|
Takashi Iwai |
b3a873 |
return -ENOMEM;
|
|
Takashi Iwai |
b3a873 |
|
|
Takashi Iwai |
b3a873 |
pos = dw_i3c_master_get_free_pos(master);
|
|
Takashi Iwai |
b3a873 |
+ if (pos < 0) {
|
|
Takashi Iwai |
b3a873 |
+ dw_i3c_master_free_xfer(xfer);
|
|
Takashi Iwai |
b3a873 |
+ return pos;
|
|
Takashi Iwai |
b3a873 |
+ }
|
|
Takashi Iwai |
b3a873 |
cmd = &xfer->cmds[0];
|
|
Takashi Iwai |
b3a873 |
cmd->cmd_hi = 0x1;
|
|
Takashi Iwai |
b3a873 |
cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |
|
|
Takashi Iwai |
b3a873 |
--
|
|
Takashi Iwai |
b3a873 |
2.31.1
|
|
Takashi Iwai |
b3a873 |
|