Michal Suchanek e0bef6
From a369d96ca55401c29ca05a41c3aa15d65948c599 Mon Sep 17 00:00:00 2001
Michal Suchanek e0bef6
From: Lijun Pan <lijunp213@gmail.com>
Michal Suchanek e0bef6
Date: Thu, 11 Feb 2021 00:43:23 -0600
Michal Suchanek e0bef6
Subject: [PATCH] ibmvnic: add comments for spinlock_t definitions
Michal Suchanek e0bef6
Michal Suchanek e0bef6
References: bsc#1184114 ltc#192237 bsc#1183871 ltc#192139
Michal Suchanek e0bef6
Patch-mainline: v5.12-rc1
Michal Suchanek e0bef6
Git-commit: a369d96ca55401c29ca05a41c3aa15d65948c599
Michal Suchanek e0bef6
Michal Suchanek e0bef6
There are several spinlock_t definitions without comments.
Michal Suchanek e0bef6
Add them.
Michal Suchanek e0bef6
Michal Suchanek e0bef6
Signed-off-by: Lijun Pan <lijunp213@gmail.com>
Michal Suchanek e0bef6
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
Michal Suchanek e0bef6
Signed-off-by: David S. Miller <davem@davemloft.net>
Michal Suchanek e0bef6
Acked-by: Michal Suchanek <msuchanek@suse.de>
Michal Suchanek e0bef6
---
Michal Suchanek e0bef6
 drivers/net/ethernet/ibm/ibmvnic.h | 10 ++++++----
Michal Suchanek e0bef6
 1 file changed, 6 insertions(+), 4 deletions(-)
Michal Suchanek e0bef6
Michal Suchanek e0bef6
diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h
Michal Suchanek e0bef6
index c09c3f6bba9f..8f73a30a7593 100644
Michal Suchanek e0bef6
--- a/drivers/net/ethernet/ibm/ibmvnic.h
Michal Suchanek e0bef6
+++ b/drivers/net/ethernet/ibm/ibmvnic.h
Michal Suchanek e0bef6
@@ -845,6 +845,7 @@ struct ibmvnic_crq_queue {
Michal Suchanek e0bef6
 	union ibmvnic_crq *msgs;
Michal Suchanek e0bef6
 	int size, cur;
Michal Suchanek e0bef6
 	dma_addr_t msg_token;
Michal Suchanek e0bef6
+	/* Used for serialization of msgs, cur */
Michal Suchanek e0bef6
 	spinlock_t lock;
Michal Suchanek e0bef6
 	bool active;
Michal Suchanek e0bef6
 	char name[32];
Michal Suchanek e0bef6
@@ -876,6 +877,7 @@ struct ibmvnic_sub_crq_queue {
Michal Suchanek e0bef6
 	unsigned int irq;
Michal Suchanek e0bef6
 	unsigned int pool_index;
Michal Suchanek e0bef6
 	int scrq_num;
Michal Suchanek e0bef6
+	/* Used for serialization of msgs, cur */
Michal Suchanek e0bef6
 	spinlock_t lock;
Michal Suchanek e0bef6
 	struct sk_buff *rx_skb_top;
Michal Suchanek e0bef6
 	struct ibmvnic_adapter *adapter;
Michal Suchanek e0bef6
@@ -1080,9 +1082,12 @@ struct ibmvnic_adapter {
Michal Suchanek e0bef6
 
Michal Suchanek e0bef6
 	struct tasklet_struct tasklet;
Michal Suchanek e0bef6
 	enum vnic_state state;
Michal Suchanek e0bef6
+	/* Used for serializatin of state field */
Michal Suchanek e0bef6
+	spinlock_t state_lock;
Michal Suchanek e0bef6
 	enum ibmvnic_reset_reason reset_reason;
Michal Suchanek e0bef6
-	spinlock_t rwi_lock;
Michal Suchanek e0bef6
 	struct list_head rwi_list;
Michal Suchanek e0bef6
+	/* Used for serialization of rwi_list */
Michal Suchanek e0bef6
+	spinlock_t rwi_lock;
Michal Suchanek e0bef6
 	struct work_struct ibmvnic_reset;
Michal Suchanek e0bef6
 	struct delayed_work ibmvnic_delayed_reset;
Michal Suchanek e0bef6
 	unsigned long resetting;
Michal Suchanek e0bef6
@@ -1096,7 +1101,4 @@ struct ibmvnic_adapter {
Michal Suchanek e0bef6
 
Michal Suchanek e0bef6
 	struct ibmvnic_tunables desired;
Michal Suchanek e0bef6
 	struct ibmvnic_tunables fallback;
Michal Suchanek e0bef6
-
Michal Suchanek e0bef6
-	/* Used for serializatin of state field */
Michal Suchanek e0bef6
-	spinlock_t state_lock;
Michal Suchanek e0bef6
 };
Michal Suchanek e0bef6
-- 
Michal Suchanek e0bef6
2.26.2
Michal Suchanek e0bef6