From 8ae4dff882eb879c17bf46574201bd37fc6bc8b5 Mon Sep 17 00:00:00 2001

From: Jakub Kicinski <kuba@kernel.org>

Date: Fri, 4 Sep 2020 21:07:49 -0700

Subject: [PATCH] ibmvnic: add missing parenthesis in do_reset()

References: bsc#1176700 ltc#188140

Patch-mainline: v5.9-rc7

Git-commit: 8ae4dff882eb879c17bf46574201bd37fc6bc8b5

Indentation and logic clearly show that this code is missing

parenthesis.

Fixes: 9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset")

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Michal Suchanek <msuchanek@suse.de>

---

 drivers/net/ethernet/ibm/ibmvnic.c | 6 ++++--

 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c

index d3a774331afc..1b702a43a5d0 100644

--- a/drivers/net/ethernet/ibm/ibmvnic.c

+++ b/drivers/net/ethernet/ibm/ibmvnic.c

@@ -2032,16 +2032,18 @@ static int do_reset(struct ibmvnic_adapter *adapter,

 		} else {

 			rc = reset_tx_pools(adapter);

-			if (rc)

+			if (rc) {

 				netdev_dbg(adapter->netdev, "reset tx pools failed (%d)\n",

 						rc);

 				goto out;

+			}

 			rc = reset_rx_pools(adapter);

-			if (rc)

+			if (rc) {

 				netdev_dbg(adapter->netdev, "reset rx pools failed (%d)\n",

 						rc);

 				goto out;

+			}

 		}

 		ibmvnic_disable_irqs(adapter);

 	}

-- 

2.28.0