From 2719cb445da5fec698e961abdf75cf9e4d61fba4 Mon Sep 17 00:00:00 2001

From: Lijun Pan <ljp@linux.ibm.com>

Date: Fri, 29 Jan 2021 19:19:05 -0600

Subject: [PATCH] ibmvnic: remove unnecessary rmb() inside ibmvnic_poll

References: bsc#1184114 ltc#192237 bsc#1183871 ltc#192139

Patch-mainline: v5.12-rc1

Git-commit: 2719cb445da5fec698e961abdf75cf9e4d61fba4

rmb() can be removed since:

1. pending_scrq() has dma_rmb() at the function end;

2. dma_rmb(), though weaker, is enough here.

Signed-off-by: Lijun Pan <ljp@linux.ibm.com>

Acked-by: Dwip Banerjee <dnbanerg@us.ibm.com>

Acked-by: Thomas Falcon <tlfalcon@linux.ibm.com>

Reviewed-by: Brian King <brking@linux.vnet.ibm.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Michal Suchanek <msuchanek@suse.de>

---

 drivers/net/ethernet/ibm/ibmvnic.c | 1 -

 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c

index 331ebca2f57a..0ed169ef1cfc 100644

--- a/drivers/net/ethernet/ibm/ibmvnic.c

+++ b/drivers/net/ethernet/ibm/ibmvnic.c

@@ -2510,7 +2510,6 @@ static int ibmvnic_poll(struct napi_struct *napi, int budget)

 		if (napi_complete_done(napi, frames_processed)) {

 			enable_scrq_irq(adapter, rx_scrq);

 			if (pending_scrq(adapter, rx_scrq)) {

-				rmb();

 				if (napi_reschedule(napi)) {

 					disable_scrq_irq(adapter, rx_scrq);

 					goto restart_poll;

-- 

2.26.2