Takashi Iwai 1bad9d
From a263456f0e27ec2f00d25119757f4d4bd656b2e9 Mon Sep 17 00:00:00 2001
Takashi Iwai 1bad9d
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Takashi Iwai 1bad9d
Date: Sun, 8 May 2022 18:55:47 +0100
Takashi Iwai 1bad9d
Subject: [PATCH] iio: accel: sca3000: Fix alignment for DMA safety
Takashi Iwai 1bad9d
Mime-version: 1.0
Takashi Iwai 1bad9d
Content-type: text/plain; charset=UTF-8
Takashi Iwai 1bad9d
Content-transfer-encoding: 8bit
Takashi Iwai 1bad9d
Git-commit: a263456f0e27ec2f00d25119757f4d4bd656b2e9
Takashi Iwai 1bad9d
Patch-mainline: v6.0-rc1
Takashi Iwai 1bad9d
References: git-fixes
Takashi Iwai 1bad9d
Takashi Iwai 1bad9d
____cacheline_aligned is insufficient guarantee for non-coherent DMA.
Takashi Iwai 1bad9d
Switch to the updated IIO_DMA_MINALIGN definition.
Takashi Iwai 1bad9d
Takashi Iwai 1bad9d
The second alignment marking is left in place to avoid doing more than
Takashi Iwai 1bad9d
the simple fix in this patch.
Takashi Iwai 1bad9d
Takashi Iwai 1bad9d
Fixes: ced5c03d360ae ("staging:iio:accel:sca3000 merge files into one.")
Takashi Iwai 1bad9d
Fixes: 152a6a884ae13 ("staging:iio:accel:sca3000 move to hybrid hard / soft buffer design.")
Takashi Iwai 1bad9d
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Takashi Iwai 1bad9d
Acked-by: Nuno Sá <nuno.sa@analog.com>
Takashi Iwai 1bad9d
Link: https://lore.kernel.org/r/20220508175712.647246-8-jic23@kernel.org
Takashi Iwai 1bad9d
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 1bad9d
Takashi Iwai 1bad9d
---
Takashi Iwai 1bad9d
 drivers/iio/accel/sca3000.c | 4 ++--
Takashi Iwai 1bad9d
 1 file changed, 2 insertions(+), 2 deletions(-)
Takashi Iwai 1bad9d
Takashi Iwai 1bad9d
diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
Takashi Iwai 1bad9d
index 08dedee76e46..87c54e41f6cc 100644
Takashi Iwai 1bad9d
--- a/drivers/iio/accel/sca3000.c
Takashi Iwai 1bad9d
+++ b/drivers/iio/accel/sca3000.c
Takashi Iwai 1bad9d
@@ -167,8 +167,8 @@ struct sca3000_state {
Takashi Iwai 1bad9d
 	int				mo_det_use_count;
Takashi Iwai 1bad9d
 	struct mutex			lock;
Takashi Iwai 1bad9d
 	/* Can these share a cacheline ? */
Takashi Iwai 1bad9d
-	u8				rx[384] ____cacheline_aligned;
Takashi Iwai 1bad9d
-	u8				tx[6] ____cacheline_aligned;
Takashi Iwai 1bad9d
+	u8				rx[384] __aligned(IIO_DMA_MINALIGN);
Takashi Iwai 1bad9d
+	u8				tx[6] __aligned(IIO_DMA_MINALIGN);
Takashi Iwai 1bad9d
 };
Takashi Iwai 1bad9d
 
Takashi Iwai 1bad9d
 /**
Takashi Iwai 1bad9d
-- 
Takashi Iwai 1bad9d
2.35.3
Takashi Iwai 1bad9d