From fde272e78e004a45c7e4976876277d7e6a5a0ede Mon Sep 17 00:00:00 2001

From: Kister Genesis Jimenez <kister.jimenez@analog.com>

Date: Mon, 15 Nov 2021 11:41:47 +0100

Subject: [PATCH] iio: gyro: adxrs290: fix data signedness

Mime-version: 1.0

Content-type: text/plain; charset=UTF-8

Content-transfer-encoding: 8bit

Git-commit: fde272e78e004a45c7e4976876277d7e6a5a0ede

Patch-mainline: v5.16-rc5

References: git-fixes

Properly sign-extend the rate and temperature data.

Fixes: 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")

Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>

Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Link: https://lore.kernel.org/r/20211115104147.18669-1-nuno.sa@analog.com

Cc: <Stable@vger.kernel.org>

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/iio/gyro/adxrs290.c | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c

index 3e0734ddafe3..600e9725da78 100644

--- a/drivers/iio/gyro/adxrs290.c

+++ b/drivers/iio/gyro/adxrs290.c

@@ -7,6 +7,7 @@

  */

 #include <linux/bitfield.h>

+#include <linux/bitops.h>

 #include <linux/delay.h>

 #include <linux/device.h>

 #include <linux/kernel.h>

@@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct iio_dev *indio_dev, const u8 cmd, int *

 		goto err_unlock;

 	}

-	*val = temp;

+	*val = sign_extend32(temp, 15);

 err_unlock:

 	mutex_unlock(&st->lock);

@@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct iio_dev *indio_dev, int *val)

 	}

 	/* extract lower 12 bits temperature reading */

-	*val = temp & 0x0FFF;

+	*val = sign_extend32(temp, 11);

 err_unlock:

 	mutex_unlock(&st->lock);

-- 

2.31.1