Gabriel Krisman Bertazi f1a0c7
From c5595975b53a487bf329eeba65b5c5f34605a4c0 Mon Sep 17 00:00:00 2001
Gabriel Krisman Bertazi f1a0c7
From: Pavel Begunkov <asml.silence@gmail.com>
Gabriel Krisman Bertazi f1a0c7
Date: Wed, 15 Jun 2022 11:23:07 +0100
Gabriel Krisman Bertazi f1a0c7
Subject: [PATCH] io_uring: make io_fill_cqe_aux honour CQE32
Gabriel Krisman Bertazi f1a0c7
Git-commit: c5595975b53a487bf329eeba65b5c5f34605a4c0
Gabriel Krisman Bertazi f1a0c7
Patch-mainline: v5.19-rc3
Gabriel Krisman Bertazi f1a0c7
References: bsc#1205205
Gabriel Krisman Bertazi f1a0c7
Gabriel Krisman Bertazi f1a0c7
Don't let io_fill_cqe_aux() post 16B cqes for CQE32 rings, neither the
Gabriel Krisman Bertazi f1a0c7
kernel nor the userspace expect this to happen.
Gabriel Krisman Bertazi f1a0c7
Gabriel Krisman Bertazi f1a0c7
Fixes: 76c68fbf1a1f9 ("io_uring: enable CQE32")
Gabriel Krisman Bertazi f1a0c7
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Gabriel Krisman Bertazi f1a0c7
Link: https://lore.kernel.org/r/64fae669fae1b7083aa15d0cd807f692b0880b9a.1655287457.git.asml.silence@gmail.com
Gabriel Krisman Bertazi f1a0c7
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Gabriel Krisman Bertazi f1a0c7
Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
Gabriel Krisman Bertazi f1a0c7
---
Gabriel Krisman Bertazi f1a0c7
 fs/io_uring.c | 5 +++++
Gabriel Krisman Bertazi f1a0c7
 1 file changed, 5 insertions(+)
Gabriel Krisman Bertazi f1a0c7
Gabriel Krisman Bertazi f1a0c7
diff --git a/fs/io_uring.c b/fs/io_uring.c
Gabriel Krisman Bertazi f1a0c7
index 792e9c95d217..5d479428d8e5 100644
Gabriel Krisman Bertazi f1a0c7
--- a/fs/io_uring.c
Gabriel Krisman Bertazi f1a0c7
+++ b/fs/io_uring.c
Gabriel Krisman Bertazi f1a0c7
@@ -2518,6 +2518,11 @@ static noinline bool io_fill_cqe_aux(struct io_ring_ctx *ctx, u64 user_data,
Gabriel Krisman Bertazi f1a0c7
 		WRITE_ONCE(cqe->user_data, user_data);
Gabriel Krisman Bertazi f1a0c7
 		WRITE_ONCE(cqe->res, res);
Gabriel Krisman Bertazi f1a0c7
 		WRITE_ONCE(cqe->flags, cflags);
Gabriel Krisman Bertazi f1a0c7
+
Gabriel Krisman Bertazi f1a0c7
+		if (ctx->flags & IORING_SETUP_CQE32) {
Gabriel Krisman Bertazi f1a0c7
+			WRITE_ONCE(cqe->big_cqe[0], 0);
Gabriel Krisman Bertazi f1a0c7
+			WRITE_ONCE(cqe->big_cqe[1], 0);
Gabriel Krisman Bertazi f1a0c7
+		}
Gabriel Krisman Bertazi f1a0c7
 		return true;
Gabriel Krisman Bertazi f1a0c7
 	}
Gabriel Krisman Bertazi f1a0c7
 	return io_cqring_event_overflow(ctx, user_data, res, cflags, 0, 0);
Gabriel Krisman Bertazi f1a0c7
-- 
Gabriel Krisman Bertazi f1a0c7
2.35.3
Gabriel Krisman Bertazi f1a0c7