Takashi Iwai f708ff
From 8ea28f13bbac05999d6136548e8b8a07d7b387c9 Mon Sep 17 00:00:00 2001
Takashi Iwai f708ff
From: Johannes Berg <johannes.berg@intel.com>
Takashi Iwai f708ff
Date: Fri, 4 Feb 2022 12:25:06 +0200
Takashi Iwai f708ff
Subject: [PATCH] iwlwifi: drv: load tlv debug data earlier
Takashi Iwai f708ff
Git-commit: 8ea28f13bbac05999d6136548e8b8a07d7b387c9
Takashi Iwai f708ff
Patch-mainline: v5.18-rc1
Takashi Iwai f708ff
References: bsc#1202131
Takashi Iwai f708ff
Takashi Iwai f708ff
There's no good reason to pick the opmode first and load this
Takashi Iwai f708ff
under the mutex, so just load it before continuing. This will
Takashi Iwai f708ff
let us load it asynchronously more easily later.
Takashi Iwai f708ff
Takashi Iwai f708ff
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Takashi Iwai f708ff
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Takashi Iwai f708ff
Link: https://lore.kernel.org/r/iwlwifi.20220204122220.a28df852f70d.Icaf6556d81bc137a459aabf0511d46c3861b0413@changeid
Takashi Iwai f708ff
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai f708ff
Takashi Iwai f708ff
---
Takashi Iwai f708ff
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 4 ++--
Takashi Iwai f708ff
 1 file changed, 2 insertions(+), 2 deletions(-)
Takashi Iwai f708ff
Takashi Iwai f708ff
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
Takashi Iwai f708ff
index 5a9e644a791c..ab52136cffb4 100644
Takashi Iwai f708ff
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
Takashi Iwai f708ff
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
Takashi Iwai f708ff
@@ -1647,6 +1647,8 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
Takashi Iwai f708ff
 	/* We have our copies now, allow OS release its copies */
Takashi Iwai f708ff
 	release_firmware(ucode_raw);
Takashi Iwai f708ff
 
Takashi Iwai f708ff
+	iwl_dbg_tlv_load_bin(drv->trans->dev, drv->trans);
Takashi Iwai f708ff
+
Takashi Iwai f708ff
 	mutex_lock(&iwlwifi_opmode_table_mtx);
Takashi Iwai f708ff
 	switch (fw->type) {
Takashi Iwai f708ff
 	case IWL_FW_DVM:
Takashi Iwai f708ff
@@ -1663,8 +1665,6 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
Takashi Iwai f708ff
 	IWL_INFO(drv, "loaded firmware version %s op_mode %s\n",
Takashi Iwai f708ff
 		 drv->fw.fw_version, op->name);
Takashi Iwai f708ff
 
Takashi Iwai f708ff
-	iwl_dbg_tlv_load_bin(drv->trans->dev, drv->trans);
Takashi Iwai f708ff
-
Takashi Iwai f708ff
 	/* add this device to the list of devices using this op_mode */
Takashi Iwai f708ff
 	list_add_tail(&drv->list, &op->drv);
Takashi Iwai f708ff
 
Takashi Iwai f708ff
-- 
Takashi Iwai f708ff
2.35.3
Takashi Iwai f708ff