From 355a8031dc174450ccad2a61c513ad7222d87a97 Mon Sep 17 00:00:00 2001

From: Damien Le Moal <damien.lemoal@wdc.com>

Date: Mon, 16 Aug 2021 10:44:47 +0900

Subject: [PATCH] libata: fix ata_host_start()

Git-commit: 355a8031dc174450ccad2a61c513ad7222d87a97

Patch-mainline: v5.15-rc1

References: git-fixes

The loop on entry of ata_host_start() may not initialize host->ops to a

non NULL value. The test on the host_stop field of host->ops must then

be preceded by a check that host->ops is not NULL.

Reported-by: kernel test robot <lkp@intel.com>

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>

Reviewed-by: Hannes Reinecke <hare@suse.de>

Link: https://lore.kernel.org/r/20210816014456.2191776-3-damien.lemoal@wdc.com

Signed-off-by: Jens Axboe <axboe@kernel.dk>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/ata/libata-core.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c

index 61c762961ca8..44f434acfce0 100644

--- a/drivers/ata/libata-core.c

+++ b/drivers/ata/libata-core.c

@@ -5573,7 +5573,7 @@ int ata_host_start(struct ata_host *host)

 			have_stop = 1;

 	}

-	if (host->ops->host_stop)

+	if (host->ops && host->ops->host_stop)

 		have_stop = 1;

 	if (have_stop) {

-- 

2.26.2