From: Richard Henderson <richard.henderson@linaro.org>

Date: Fri, 10 Jan 2020 14:54:18 +0000

Subject: linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check

Git-commit: 904caa6413c87aacbf7d0682da617c39ca18cf1a

Patch-mainline: v5.6-rc1

References: git-fixes

We must not use the pointer output without validating the

success of the random read.

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Signed-off-by: Richard Henderson <rth@twiddle.net>

Signed-off-by: Mark Brown <broonie@kernel.org>

Link: https://lore.kernel.org/r/20200110145422.49141-7-broonie@kernel.org

Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Acked-by: Lee Duncan <lduncan@suse.com>

---

 include/linux/random.h | 8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/random.h b/include/linux/random.h

index ea0e2f5f1ec5..d319f9a1e429 100644

--- a/include/linux/random.h

+++ b/include/linux/random.h

@@ -167,19 +167,19 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed)

 #ifdef CONFIG_ARCH_RANDOM

 # include <asm/archrandom.h>

 #else

-static inline bool arch_get_random_long(unsigned long *v)

+static inline bool __must_check arch_get_random_long(unsigned long *v)

 {

 	return false;

 }

-static inline bool arch_get_random_int(unsigned int *v)

+static inline bool __must_check arch_get_random_int(unsigned int *v)

 {

 	return false;

 }

-static inline bool arch_get_random_seed_long(unsigned long *v)

+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)

 {

 	return false;

 }

-static inline bool arch_get_random_seed_int(unsigned int *v)

+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)

 {

 	return false;

 }