Patrik Jakobsson a8f955
From 15342f930ebebcfe36f2415049736a77d7d2e045 Mon Sep 17 00:00:00 2001
Patrik Jakobsson a8f955
From: Miaoqian Lin <linmq006@gmail.com>
Patrik Jakobsson a8f955
Date: Mon, 13 Dec 2021 07:21:15 +0000
Patrik Jakobsson a8f955
Subject: malidp: Fix NULL vs IS_ERR() checking
Patrik Jakobsson a8f955
Git-commit: 15342f930ebebcfe36f2415049736a77d7d2e045
Patrik Jakobsson a8f955
Patch-mainline: v5.19-rc1
Patrik Jakobsson a8f955
References: bsc#1208843 CVE-2023-23004
Patrik Jakobsson a8f955
Patrik Jakobsson a8f955
The get_sg_table() function does not return NULL.
Patrik Jakobsson a8f955
It returns error pointers.
Patrik Jakobsson a8f955
Patrik Jakobsson a8f955
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Patrik Jakobsson a8f955
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Patrik Jakobsson a8f955
Link: https://lore.kernel.org/dri-devel/20211213072115.18098-1-linmq006@gmail.com/
Patrik Jakobsson a8f955
Acked-by: Patrik Jakobsson <pjakobsson@suse.de>
Patrik Jakobsson a8f955
---
Patrik Jakobsson a8f955
 drivers/gpu/drm/arm/malidp_planes.c |    2 +-
Patrik Jakobsson a8f955
 1 file changed, 1 insertion(+), 1 deletion(-)
Patrik Jakobsson a8f955
Patrik Jakobsson a8f955
--- a/drivers/gpu/drm/arm/malidp_planes.c
Patrik Jakobsson a8f955
+++ b/drivers/gpu/drm/arm/malidp_planes.c
Patrik Jakobsson a8f955
@@ -346,7 +346,7 @@
Patrik Jakobsson a8f955
 		else
Patrik Jakobsson a8f955
 			sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
Patrik Jakobsson a8f955
 
Patrik Jakobsson a8f955
-		if (!sgt)
Patrik Jakobsson a8f955
+		if (IS_ERR(sgt))
Patrik Jakobsson a8f955
 			return false;
Patrik Jakobsson a8f955
 
Patrik Jakobsson a8f955
 		sgl = sgt->sgl;