Takashi Iwai ca333b
From fe0acab448f68c3146235afe03fb932e242ec94c Mon Sep 17 00:00:00 2001
Takashi Iwai ca333b
From: Yangbo Lu <yangbo.lu@nxp.com>
Takashi Iwai ca333b
Date: Mon, 16 Dec 2019 11:18:42 +0800
Takashi Iwai ca333b
Subject: [PATCH] mmc: sdhci-of-esdhc: fix P2020 errata handling
Takashi Iwai ca333b
Git-commit: fe0acab448f68c3146235afe03fb932e242ec94c
Takashi Iwai ca333b
Patch-mainline: v5.5-rc3
Takashi Iwai ca333b
References: bsc#1051510
Takashi Iwai ca333b
Takashi Iwai ca333b
Two previous patches introduced below quirks for P2020 platforms.
Takashi Iwai ca333b
- SDHCI_QUIRK_RESET_AFTER_REQUEST
Takashi Iwai ca333b
- SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
Takashi Iwai ca333b
Takashi Iwai ca333b
The patches made a mistake to add them in quirks2 of sdhci_host
Takashi Iwai ca333b
structure, while they were defined for quirks.
Takashi Iwai ca333b
	host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
Takashi Iwai ca333b
	host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
Takashi Iwai ca333b
Takashi Iwai ca333b
This patch is to fix them.
Takashi Iwai ca333b
	host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
Takashi Iwai ca333b
	host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
Takashi Iwai ca333b
Takashi Iwai ca333b
Fixes: 05cb6b2a66fa ("mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support")
Takashi Iwai ca333b
Fixes: a46e42712596 ("mmc: sdhci-of-esdhc: add erratum eSDHC5 support")
Takashi Iwai ca333b
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
Takashi Iwai ca333b
Cc: stable@vger.kernel.org
Takashi Iwai ca333b
Link: https://lore.kernel.org/r/20191216031842.40068-1-yangbo.lu@nxp.com
Takashi Iwai ca333b
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Takashi Iwai ca333b
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai ca333b
Takashi Iwai ca333b
---
Takashi Iwai ca333b
 drivers/mmc/host/sdhci-of-esdhc.c | 4 ++--
Takashi Iwai ca333b
 1 file changed, 2 insertions(+), 2 deletions(-)
Takashi Iwai ca333b
Takashi Iwai ca333b
diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
Takashi Iwai ca333b
index 7f87a90bf56a..4ca640e6fd55 100644
Takashi Iwai ca333b
--- a/drivers/mmc/host/sdhci-of-esdhc.c
Takashi Iwai ca333b
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
Takashi Iwai ca333b
@@ -1300,8 +1300,8 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
Takashi Iwai ca333b
 		host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ;
Takashi Iwai ca333b
 
Takashi Iwai ca333b
 	if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) {
Takashi Iwai ca333b
-		host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
Takashi Iwai ca333b
-		host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
Takashi Iwai ca333b
+		host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
Takashi Iwai ca333b
+		host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
Takashi Iwai ca333b
 	}
Takashi Iwai ca333b
 
Takashi Iwai ca333b
 	if (of_device_is_compatible(np, "fsl,p5040-esdhc") ||
Takashi Iwai ca333b
-- 
Takashi Iwai ca333b
2.16.4
Takashi Iwai ca333b