Olaf Hering 6e0a89
From: Chuhong Yuan <hslester96@gmail.com>
Olaf Hering 6e0a89
Date: Thu, 7 May 2020 23:13:43 +0800
Olaf Hering 6e0a89
Patch-mainline: v5.8-rc1
Olaf Hering 6e0a89
References: git-fixes
Olaf Hering 6e0a89
Subject: uio_hv_generic: add missed sysfs_remove_bin_file
Olaf Hering 6e0a89
Git-commit: 7066c2f61ce49b131026fec68ed1c9b0d0d9a05a
Olaf Hering 6e0a89
Olaf Hering 6e0a89
This driver calls sysfs_create_bin_file() in probe, but forgets to
Olaf Hering 6e0a89
call sysfs_remove_bin_file() in remove.
Olaf Hering 6e0a89
Add the missed call to fix it.
Olaf Hering 6e0a89
Olaf Hering 6e0a89
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Olaf Hering 6e0a89
Link: https://lore.kernel.org/r/20200507151343.792816-1-hslester96@gmail.com
Olaf Hering 6e0a89
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Olaf Hering 6e0a89
Acked-by: Olaf Hering <ohering@suse.de>
Olaf Hering 6e0a89
---
Olaf Hering 6e0a89
 drivers/uio/uio_hv_generic.c | 1 +
Olaf Hering 6e0a89
 1 file changed, 1 insertion(+)
Olaf Hering 6e0a89
Olaf Hering 6e0a89
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
Olaf Hering 6e0a89
--- a/drivers/uio/uio_hv_generic.c
Olaf Hering 6e0a89
+++ b/drivers/uio/uio_hv_generic.c
Olaf Hering 6e0a89
@@ -361,6 +361,7 @@ hv_uio_remove(struct hv_device *dev)
Olaf Hering 6e0a89
 	if (!pdata)
Olaf Hering 6e0a89
 		return 0;
Olaf Hering 6e0a89
 
Olaf Hering 6e0a89
+	sysfs_remove_bin_file(&dev->channel->kobj, &ring_buffer_bin_attr);
Olaf Hering 6e0a89
 	uio_unregister_device(&pdata->info);
Olaf Hering 6e0a89
 	hv_uio_cleanup(dev, pdata);
Olaf Hering 6e0a89
 	hv_set_drvdata(dev, NULL);