From: Jason Gunthorpe <jgg@mellanox.com>

Date: Tue, 14 Apr 2020 12:27:08 -0300

Subject: net/cxgb4: Check the return from t4_query_params properly

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Patch-mainline: v5.7-rc2

Git-commit: c799fca8baf18d1bbbbad6c3b736eefbde8bdb90

References: git-fixes

Positive return values are also failures that don't set val,

although this probably can't happen. Fixes gcc 10 warning:

drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function ‘t4_phy_fw_ver’:

drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3747:14: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]

 3747 |  *phy_fw_ver = val;

Fixes: 01b6961410b7 ("cxgb4: Add PHY firmware support for T420-BT cards")

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

Signed-off-by: David S. Miller <davem@davemloft.net>

Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

---

 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c |    2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

@@ -3748,7 +3748,7 @@ int t4_phy_fw_ver(struct adapter *adap,

 		 FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_VERSION));

 	ret = t4_query_params(adap, adap->mbox, adap->pf, 0, 1,

 			      &param, &val;;

-	if (ret < 0)

+	if (ret)

 		return ret;

 	*phy_fw_ver = val;

 	return 0;