bbd1c8
From 71a188c4013e1b170bd7377851302a9b54d1bcc2 Mon Sep 17 00:00:00 2001
bbd1c8
From: Zhang Changzhong <zhangchangzhong@huawei.com>
bbd1c8
Date: Fri, 13 Nov 2020 14:49:33 +0800
bbd1c8
Subject: [PATCH 03/14] net: ethernet: ti: cpsw: fix error return code in
bbd1c8
 cpsw_probe()
bbd1c8
Git-commit: 35f735c665114840dcd3142f41148d07870f51f7
bbd1c8
Patch-mainline: v5.10-rc5
bbd1c8
References: git-fixes
bbd1c8
bbd1c8
Fix to return a negative error code from the error handling
bbd1c8
case instead of 0, as done elsewhere in this function.
bbd1c8
bbd1c8
Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
bbd1c8
Reported-by: Hulk Robot <hulkci@huawei.com>
bbd1c8
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
bbd1c8
Link: https://lore.kernel.org/r/1605250173-18438-1-git-send-email-zhangchangzhong@huawei.com
bbd1c8
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
bbd1c8
Signed-off-by: Denis Kirjanov <denis.kirjanov@suse.com>
bbd1c8
---
bbd1c8
 drivers/net/ethernet/ti/cpsw.c | 1 +
bbd1c8
 1 file changed, 1 insertion(+)
bbd1c8
bbd1c8
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
bbd1c8
index 978eaded8f00..59b0433a780c 100644
bbd1c8
--- a/drivers/net/ethernet/ti/cpsw.c
bbd1c8
+++ b/drivers/net/ethernet/ti/cpsw.c
bbd1c8
@@ -2876,6 +2876,7 @@ static int cpsw_probe(struct platform_device *pdev)
bbd1c8
 				       CPSW_MAX_QUEUES, CPSW_MAX_QUEUES);
bbd1c8
 	if (!ndev) {
bbd1c8
 		dev_err(dev, "error allocating net_device\n");
bbd1c8
+		ret = -ENOMEM;
bbd1c8
 		goto clean_cpts;
bbd1c8
 	}
bbd1c8
 
bbd1c8
-- 
bbd1c8
2.16.4
bbd1c8