From: Miaoqian Lin <linmq006@gmail.com>

Date: Wed, 22 Dec 2021 06:54:53 +0000

Subject: net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources

Patch-mainline: v5.16-rc8

Git-commit: 6b8b42585886c59a008015083282aae434349094

References: bsc#1208845 CVE-2023-23006

The mlx5_get_uars_page() function  returns error pointers.

Using IS_ERR() to check the return value to fix this.

Fixes: 4ec9e7b02697 ("net/mlx5: DR, Expose steering domain functionality")

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

---

 drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c |    5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c

+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c

@@ -2,6 +2,7 @@

 /* Copyright (c) 2019 Mellanox Technologies. */

 #include <linux/mlx5/eswitch.h>

+#include <linux/err.h>

 #include "dr_types.h"

 static int dr_domain_init_cache(struct mlx5dr_domain *dmn)

@@ -64,9 +65,9 @@ static int dr_domain_init_resources(stru

 	}

 	dmn->uar = mlx5_get_uars_page(dmn->mdev);

-	if (!dmn->uar) {

+	if (IS_ERR(dmn->uar)) {

 		mlx5dr_err(dmn, "Couldn't allocate UAR\n");

-		ret = -ENOMEM;

+		ret = PTR_ERR(dmn->uar);

 		goto clean_pd;

 	}