Hannes Reinecke 8958a0
From: Hou Pu <houpu.main@gmail.com>
Hannes Reinecke 8958a0
Date: Fri, 9 Jul 2021 10:32:47 +0800
Hannes Reinecke 8958a0
Subject: [PATCH] nvme-fabrics: remove superfluous nvmf_host_put in
Hannes Reinecke 8958a0
 nvmf_parse_options
Hannes Reinecke 8958a0
Git-commit: e23439e977ed2b247912c2b5c6945ef1bc380100
Hannes Reinecke 8958a0
Patch-mainline: v5.15-rc1
Hannes Reinecke 8958a0
References: git-fixes
Hannes Reinecke 8958a0
Hannes Reinecke 8958a0
Opts->host is NULL there. It is checked just before. So remove
Hannes Reinecke 8958a0
nvmf_host_put. It is introduced by commit 59a2f3f00fd7 ("nvme: fix
Hannes Reinecke 8958a0
potential memory leak in option parsing").
Hannes Reinecke 8958a0
Hannes Reinecke 8958a0
Signed-off-by: Hou Pu <houpu.main@gmail.com>
Hannes Reinecke 8958a0
Signed-off-by: Christoph Hellwig <hch@lst.de>
Hannes Reinecke 8958a0
Acked-by: Hannes Reinecke <hare@suse.com>
Hannes Reinecke 8958a0
---
Hannes Reinecke 8958a0
 drivers/nvme/host/fabrics.c | 1 -
Hannes Reinecke 8958a0
 1 file changed, 1 deletion(-)
Hannes Reinecke 8958a0
Hannes Reinecke 8958a0
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
Hannes Reinecke 8958a0
index a5469fd9d4c3..668c6bb7a567 100644
Hannes Reinecke 8958a0
--- a/drivers/nvme/host/fabrics.c
Hannes Reinecke 8958a0
+++ b/drivers/nvme/host/fabrics.c
Hannes Reinecke 8958a0
@@ -719,7 +719,6 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
Hannes Reinecke 8958a0
 				ret = -EINVAL;
Hannes Reinecke 8958a0
 				goto out;
Hannes Reinecke 8958a0
 			}
Hannes Reinecke 8958a0
-			nvmf_host_put(opts->host);
Hannes Reinecke 8958a0
 			opts->host = nvmf_host_add(p);
Hannes Reinecke 8958a0
 			kfree(p);
Hannes Reinecke 8958a0
 			if (!opts->host) {
Hannes Reinecke 8958a0
-- 
Hannes Reinecke 8958a0
2.29.2
Hannes Reinecke 8958a0