From: Keith Busch <kbusch@kernel.org>

Date: Sat, 7 Dec 2019 01:51:54 +0900

Subject: [PATCH] nvme/pci: Fix write and poll queue types

Git-commit: 3f68baf706ec68c4120867c25bc439c845fe3e17

Patch-mainline: v5.5-rc2

References: bsc#1169045

The number of poll or write queues should never be negative. Use unsigned

types so that it's not possible to break have the driver not allocate

any queues.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Keith Busch <kbusch@kernel.org>

Acked-by: Hannes Reinecke <hare@suse.com>

---

 drivers/nvme/host/pci.c | 8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c

index 0590640ba62c..446ea9c175fe 100644

--- a/drivers/nvme/host/pci.c

+++ b/drivers/nvme/host/pci.c

@@ -68,14 +68,14 @@ static int io_queue_depth = 1024;

 module_param_cb(io_queue_depth, &io_queue_depth_ops, &io_queue_depth, 0644);

 MODULE_PARM_DESC(io_queue_depth, "set io queue depth, should >= 2");

-static int write_queues;

-module_param(write_queues, int, 0644);

+static unsigned int write_queues;

+module_param(write_queues, uint, 0644);

 MODULE_PARM_DESC(write_queues,

 	"Number of queues to use for writes. If not set, reads and writes "

 	"will share a queue set.");

-static int poll_queues;

-module_param(poll_queues, int, 0644);

+static unsigned int poll_queues;

+module_param(poll_queues, uint, 0644);

 MODULE_PARM_DESC(poll_queues, "Number of queues to use for polled IO.");

 struct nvme_dev;

-- 

2.16.4