Hannes Reinecke a52e5d
From: Keith Busch <kbusch@kernel.org>
Hannes Reinecke a52e5d
Date: Fri, 6 Aug 2021 08:41:43 -0700
Hannes Reinecke a52e5d
Subject: [PATCH] nvme-tcp: pair send_mutex init with destroy
Hannes Reinecke a52e5d
Git-commit: d48f92cd2739258a1292be56bbeadb5b6a57ea09
Hannes Reinecke a52e5d
Patch-mainline: v5.15-rc1
Hannes Reinecke a52e5d
References: git-fixes
Hannes Reinecke a52e5d
Hannes Reinecke a52e5d
Each mutex_init() should have a corresponding mutex_destroy().
Hannes Reinecke a52e5d
Hannes Reinecke a52e5d
Signed-off-by: Keith Busch <kbusch@kernel.org>
Hannes Reinecke a52e5d
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Hannes Reinecke a52e5d
Signed-off-by: Christoph Hellwig <hch@lst.de>
Hannes Reinecke a52e5d
Acked-by: Hannes Reinecke <hare@suse.com>
Hannes Reinecke a52e5d
---
Hannes Reinecke a52e5d
 drivers/nvme/host/tcp.c | 2 ++
Hannes Reinecke a52e5d
 1 file changed, 2 insertions(+)
Hannes Reinecke a52e5d
Hannes Reinecke a52e5d
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
Hannes Reinecke a52e5d
index 0a97ba02f61e..95d4cf777d24 100644
Hannes Reinecke a52e5d
--- a/drivers/nvme/host/tcp.c
Hannes Reinecke a52e5d
+++ b/drivers/nvme/host/tcp.c
Hannes Reinecke a52e5d
@@ -1220,6 +1220,7 @@ static void nvme_tcp_free_queue(struct nvme_ctrl *nctrl, int qid)
Hannes Reinecke a52e5d
 
Hannes Reinecke a52e5d
 	sock_release(queue->sock);
Hannes Reinecke a52e5d
 	kfree(queue->pdu);
Hannes Reinecke a52e5d
+	mutex_destroy(&queue->send_mutex);
Hannes Reinecke a52e5d
 	mutex_destroy(&queue->queue_lock);
Hannes Reinecke a52e5d
 }
Hannes Reinecke a52e5d
 
Hannes Reinecke a52e5d
@@ -1525,6 +1526,7 @@ static int nvme_tcp_alloc_queue(struct nvme_ctrl *nctrl,
Hannes Reinecke a52e5d
 	sock_release(queue->sock);
Hannes Reinecke a52e5d
 	queue->sock = NULL;
Hannes Reinecke a52e5d
 err_destroy_mutex:
Hannes Reinecke a52e5d
+	mutex_destroy(&queue->send_mutex);
Hannes Reinecke a52e5d
 	mutex_destroy(&queue->queue_lock);
Hannes Reinecke a52e5d
 	return ret;
Hannes Reinecke a52e5d
 }
Hannes Reinecke a52e5d
-- 
Hannes Reinecke a52e5d
2.29.2
Hannes Reinecke a52e5d