From: James Smart <jsmart2021@gmail.com>

Date: Tue, 31 Mar 2020 09:49:55 -0700

Subject: [PATCH] nvmet-fc: add LS failure messages

Git-commit: 1b435f26db2eb9d13ebcf4a53b58039ae99ac093

Git-repo: git://git.infradead.org/nvme.git

Patch-mainline: Queued in subsystem maintainer repository

References: bsc#1169045

Add LS reception failure messages

Signed-off-by: James Smart <jsmart2021@gmail.com>

Reviewed-by: Hannes Reinecke <hare@suse.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Hannes Reinecke <hare@suse.com>

---

 drivers/nvme/target/fc.c | 22 +++++++++++++++++++---

 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c

index 5739df7edc59..a91c443c9098 100644

--- a/drivers/nvme/target/fc.c

+++ b/drivers/nvme/target/fc.c

@@ -1598,15 +1598,31 @@ nvmet_fc_rcv_ls_req(struct nvmet_fc_target_port *target_port,

 {

 	struct nvmet_fc_tgtport *tgtport = targetport_to_tgtport(target_port);

 	struct nvmet_fc_ls_iod *iod;

-

-	if (lsreqbuf_len > sizeof(union nvmefc_ls_requests))

+	struct fcnvme_ls_rqst_w0 *w0 = (struct fcnvme_ls_rqst_w0 *)lsreqbuf;

+

+	if (lsreqbuf_len > sizeof(union nvmefc_ls_requests)) {

+		dev_info(tgtport->dev,

+			"RCV %s LS failed: payload too large (%d)\n",

+			(w0->ls_cmd <= NVME_FC_LAST_LS_CMD_VALUE) ?

+				nvmefc_ls_names[w0->ls_cmd] : "",

+			lsreqbuf_len);

 		return -E2BIG;

+	}

-	if (!nvmet_fc_tgtport_get(tgtport))

+	if (!nvmet_fc_tgtport_get(tgtport)) {

+		dev_info(tgtport->dev,

+			"RCV %s LS failed: target deleting\n",

+			(w0->ls_cmd <= NVME_FC_LAST_LS_CMD_VALUE) ?

+				nvmefc_ls_names[w0->ls_cmd] : "");

 		return -ESHUTDOWN;

+	}

 	iod = nvmet_fc_alloc_ls_iod(tgtport);

 	if (!iod) {

+		dev_info(tgtport->dev,

+			"RCV %s LS failed: context allocation failed\n",

+			(w0->ls_cmd <= NVME_FC_LAST_LS_CMD_VALUE) ?

+				nvmefc_ls_names[w0->ls_cmd] : "");

 		nvmet_fc_tgtport_put(tgtport);

 		return -ENOENT;

 	}

-- 

2.16.4