Blame patches.suse/nvmet-tcp-Don-t-check-data_len-in-nvmet_tcp_map_data.patch
|
Hannes Reinecke |
c4d69f |
From: Logan Gunthorpe <logang@deltatee.com>
|
|
Hannes Reinecke |
c4d69f |
Date: Wed, 23 Oct 2019 10:35:39 -0600
|
|
Hannes Reinecke |
c4d69f |
Subject: [PATCH] nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()
|
|
Hannes Reinecke |
c4d69f |
Git-commit: e0bace71779d602e419a2f3b35f3bff2cfc638a3
|
|
Hannes Reinecke |
c4d69f |
Patch-mainline: v5.5-rc1
|
|
Hannes Reinecke |
c4d69f |
References: bsc#1169045
|
|
Hannes Reinecke |
c4d69f |
|
|
Hannes Reinecke |
c4d69f |
None of the other transports check data_len which is verified
|
|
Hannes Reinecke |
c4d69f |
in core code. The function should instead check that the sgl length
|
|
Hannes Reinecke |
c4d69f |
is non-zero.
|
|
Hannes Reinecke |
c4d69f |
|
|
Hannes Reinecke |
c4d69f |
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
|
|
Hannes Reinecke |
c4d69f |
Reviewed-by: Christoph Hellwig <hch@lst.de>
|
|
Hannes Reinecke |
c4d69f |
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
|
|
Hannes Reinecke |
c4d69f |
Signed-off-by: Keith Busch <kbusch@kernel.org>
|
|
Hannes Reinecke |
c4d69f |
Signed-off-by: Jens Axboe <axboe@kernel.dk>
|
|
Hannes Reinecke |
c4d69f |
Acked-by: Hannes Reinecke <hare@suse.com>
|
|
Hannes Reinecke |
c4d69f |
---
|
|
Hannes Reinecke |
c4d69f |
drivers/nvme/target/tcp.c | 2 +-
|
|
Hannes Reinecke |
c4d69f |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
Hannes Reinecke |
c4d69f |
|
|
Hannes Reinecke |
c4d69f |
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
|
|
Hannes Reinecke |
c4d69f |
index d535080b781f..1e2d92f818ad 100644
|
|
Hannes Reinecke |
c4d69f |
--- a/drivers/nvme/target/tcp.c
|
|
Hannes Reinecke |
c4d69f |
+++ b/drivers/nvme/target/tcp.c
|
|
Hannes Reinecke |
c4d69f |
@@ -320,7 +320,7 @@ static int nvmet_tcp_map_data(struct nvmet_tcp_cmd *cmd)
|
|
Hannes Reinecke |
c4d69f |
struct nvme_sgl_desc *sgl = &cmd->req.cmd->common.dptr.sgl;
|
|
Hannes Reinecke |
c4d69f |
u32 len = le32_to_cpu(sgl->length);
|
|
Hannes Reinecke |
c4d69f |
|
|
Hannes Reinecke |
c4d69f |
- if (!cmd->req.data_len)
|
|
Hannes Reinecke |
c4d69f |
+ if (!len)
|
|
Hannes Reinecke |
c4d69f |
return 0;
|
|
Hannes Reinecke |
c4d69f |
|
|
Hannes Reinecke |
c4d69f |
if (sgl->type == ((NVME_SGL_FMT_DATA_DESC << 4) |
|
|
Hannes Reinecke |
c4d69f |
--
|
|
Hannes Reinecke |
c4d69f |
2.16.4
|
|
Hannes Reinecke |
c4d69f |
|