Hannes Reinecke 870d12
From: Israel Rukshin <israelr@mellanox.com>
Hannes Reinecke 870d12
Date: Sun, 13 Oct 2019 19:57:32 +0300
Hannes Reinecke 870d12
Subject: [PATCH] nvmet: use bio_io_error instead of duplicating it
Hannes Reinecke 870d12
Git-commit: 4d764bb9a92bc63afc3befe36a0bedfddff1398a
Hannes Reinecke 870d12
Patch-mainline: v5.5-rc1
Hannes Reinecke 870d12
References: bsc#1169045
Hannes Reinecke 870d12
Hannes Reinecke 870d12
This commit doesn't change any logic.
Hannes Reinecke 870d12
Hannes Reinecke 870d12
Signed-off-by: Israel Rukshin <israelr@mellanox.com>
Hannes Reinecke 870d12
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Hannes Reinecke 870d12
Reviewed-by: Christoph Hellwig <hch@lst.de>
Hannes Reinecke 870d12
Signed-off-by: Keith Busch <kbusch@kernel.org>
Hannes Reinecke 870d12
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Hannes Reinecke 870d12
Acked-by: Hannes Reinecke <hare@suse.com>
Hannes Reinecke 870d12
---
Hannes Reinecke 870d12
 drivers/nvme/target/io-cmd-bdev.c | 8 +++-----
Hannes Reinecke 870d12
 1 file changed, 3 insertions(+), 5 deletions(-)
Hannes Reinecke 870d12
Hannes Reinecke 870d12
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
Hannes Reinecke 870d12
index 32008d85172b..f2618dc2ef3a 100644
Hannes Reinecke 870d12
--- a/drivers/nvme/target/io-cmd-bdev.c
Hannes Reinecke 870d12
+++ b/drivers/nvme/target/io-cmd-bdev.c
Hannes Reinecke 870d12
@@ -261,12 +261,10 @@ static void nvmet_bdev_execute_discard(struct nvmet_req *req)
Hannes Reinecke 870d12
 	if (bio) {
Hannes Reinecke 870d12
 		bio->bi_private = req;
Hannes Reinecke 870d12
 		bio->bi_end_io = nvmet_bio_done;
Hannes Reinecke 870d12
-		if (status) {
Hannes Reinecke 870d12
-			bio->bi_status = BLK_STS_IOERR;
Hannes Reinecke 870d12
-			bio_endio(bio);
Hannes Reinecke 870d12
-		} else {
Hannes Reinecke 870d12
+		if (status)
Hannes Reinecke 870d12
+			bio_io_error(bio);
Hannes Reinecke 870d12
+		else
Hannes Reinecke 870d12
 			submit_bio(bio);
Hannes Reinecke 870d12
-		}
Hannes Reinecke 870d12
 	} else {
Hannes Reinecke 870d12
 		nvmet_req_complete(req, status);
Hannes Reinecke 870d12
 	}
Hannes Reinecke 870d12
-- 
Hannes Reinecke 870d12
2.16.4
Hannes Reinecke 870d12