From d0afd44c05f8f4e4c91487c02d43c87a31552462 Mon Sep 17 00:00:00 2001

From: Nicholas Piggin <npiggin@gmail.com>

Date: Tue, 5 Oct 2021 00:56:39 +1000

Subject: [PATCH] powerpc/traps: do not enable irqs in _exception

References: bsc#1065729

Patch-mainline: v5.15-rc5

Git-commit: d0afd44c05f8f4e4c91487c02d43c87a31552462

_exception can be called by machine check handlers when the MCE hits

user code (e.g., pseries and powernv). This will enable local irqs

because, which is a dicey thing to do in NMI or hard irq context.

This seemed to worked out okay because a userspace MCE can basically be

treated like a synchronous interrupt (after async / imprecise MCEs are

filtered out). Since NMI and hard irq handlers have started growing

nmi_enter / irq_enter, and more irq state sanity checks, this has

started to cause problems (or at least trigger warnings).

The Fixes tag to the commit which introduced this rather than try to

work out exactly which commit was the first that could possibly cause a

problem because that may be difficult to prove.

Fixes: 9f2f79e3a3c1 ("powerpc: Disable interrupts in 64-bit kernel FP and vector faults")

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Link: https://lore.kernel.org/r/20211004145642.1331214-3-npiggin@gmail.com

Acked-by: Michal Suchanek <msuchanek@suse.de>

---

 arch/powerpc/kernel/traps.c | 12 +++++++++---

 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c

index aac8c0412ff9..e453b666613b 100644

--- a/arch/powerpc/kernel/traps.c

+++ b/arch/powerpc/kernel/traps.c

@@ -340,10 +340,16 @@ static bool exception_common(int signr, struct pt_regs *regs, int code,

 		return false;

 	}

-	show_signal_msg(signr, regs, code, addr);

+	/*

+	 * Must not enable interrupts even for user-mode exception, because

+	 * this can be called from machine check, which may be a NMI or IRQ

+	 * which don't like interrupts being enabled. Could check for

+	 * in_hardirq || in_nmi perhaps, but there doesn't seem to be a good

+	 * reason why _exception() should enable irqs for an exception handler,

+	 * the handlers themselves do that directly.

+	 */

-	if (arch_irqs_disabled())

-		interrupt_cond_local_irq_enable(regs);

+	show_signal_msg(signr, regs, code, addr);

 	current->thread.trap_nr = code;

-- 

2.31.1