From 18dbfcdedc802f9500b2c29794f22a31d27639c0 Mon Sep 17 00:00:00 2001

From: Ammar Faizi <ammarfaizi2@gmail.com>

Date: Sun, 26 Dec 2021 20:54:02 +0700

Subject: [PATCH] powerpc/xive: Add missing null check after calling kmalloc

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

References: bsc#1177437 ltc#188522 jsc#SLE-13294 git-fixes

Patch-mainline: v5.17-rc1

Git-commit: 18dbfcdedc802f9500b2c29794f22a31d27639c0

Commit 930914b7d528fc ("powerpc/xive: Add a debugfs file to dump

internal XIVE state") forgot to add a null check.

Add it.

Fixes: 930914b7d528fc6b0249bffc00564100bcf6ef75 ("powerpc/xive: Add a debugfs file to dump internal XIVE state")

Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Link: https://lore.kernel.org/r/20211226135314.251221-1-ammar.faizi@intel.com

Acked-by: Michal Suchanek <msuchanek@suse.de>

---

 arch/powerpc/sysdev/xive/spapr.c | 3 +++

 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c

index dfc4634335cc..928f95004501 100644

--- a/arch/powerpc/sysdev/xive/spapr.c

+++ b/arch/powerpc/sysdev/xive/spapr.c

@@ -653,6 +653,9 @@ static int xive_spapr_debug_show(struct seq_file *m, void *private)

 	struct xive_irq_bitmap *xibm;

 	char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);

+	if (!buf)

+		return -ENOMEM;

+

 	list_for_each_entry(xibm, &xive_irq_bitmaps, list) {

 		memset(buf, 0, PAGE_SIZE);

 		bitmap_print_to_pagebuf(true, buf, xibm->bitmap, xibm->count);

-- 

2.31.1