|
Petr Mladek |
d34d07 |
From df5b0ab3e08a156701b537809914b339b0daa526 Mon Sep 17 00:00:00 2001
|
|
Petr Mladek |
d34d07 |
From: Matteo Croce <mcroce@microsoft.com>
|
|
Petr Mladek |
d34d07 |
Date: Fri, 13 Nov 2020 22:52:07 -0800
|
|
Petr Mladek |
d34d07 |
Subject: [PATCH] reboot: fix overflow parsing reboot cpu number
|
|
Petr Mladek |
d34d07 |
Git-commit: df5b0ab3e08a156701b537809914b339b0daa526
|
|
Petr Mladek |
d34d07 |
Patch-mainline: v5.10-rc4
|
|
Petr Mladek |
d34d07 |
References: bsc#1179421
|
|
Petr Mladek |
d34d07 |
|
|
Petr Mladek |
d34d07 |
Limit the CPU number to num_possible_cpus(), because setting it to a
|
|
Petr Mladek |
d34d07 |
value lower than INT_MAX but higher than NR_CPUS produces the following
|
|
Petr Mladek |
d34d07 |
error on reboot and shutdown:
|
|
Petr Mladek |
d34d07 |
|
|
Petr Mladek |
d34d07 |
BUG: unable to handle page fault for address: ffffffff90ab1bb0
|
|
Petr Mladek |
d34d07 |
#PF: supervisor read access in kernel mode
|
|
Petr Mladek |
d34d07 |
#PF: error_code(0x0000) - not-present page
|
|
Petr Mladek |
d34d07 |
PGD 1c09067 P4D 1c09067 PUD 1c0a063 PMD 0
|
|
Petr Mladek |
d34d07 |
Oops: 0000 [#1] SMP
|
|
Petr Mladek |
d34d07 |
CPU: 1 PID: 1 Comm: systemd-shutdow Not tainted 5.9.0-rc8-kvm #110
|
|
Petr Mladek |
d34d07 |
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
|
|
Petr Mladek |
d34d07 |
RIP: 0010:migrate_to_reboot_cpu+0xe/0x60
|
|
Petr Mladek |
d34d07 |
Code: ea ea 00 48 89 fa 48 c7 c7 30 57 f1 81 e9 fa ef ff ff 66 2e 0f 1f 84 00 00 00 00 00 53 8b 1d d5 ea ea 00 e8 14 33 fe ff 89 da <48> 0f a3 15 ea fc bd 00 48 89 d0 73 29 89 c2 c1 e8 06 65 48 8b 3c
|
|
Petr Mladek |
d34d07 |
RSP: 0018:ffffc90000013e08 EFLAGS: 00010246
|
|
Petr Mladek |
d34d07 |
RAX: ffff88801f0a0000 RBX: 0000000077359400 RCX: 0000000000000000
|
|
Petr Mladek |
d34d07 |
RDX: 0000000077359400 RSI: 0000000000000002 RDI: ffffffff81c199e0
|
|
Petr Mladek |
d34d07 |
RBP: ffffffff81c1e3c0 R08: ffff88801f41f000 R09: ffffffff81c1e348
|
|
Petr Mladek |
d34d07 |
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
|
|
Petr Mladek |
d34d07 |
R13: 00007f32bedf8830 R14: 00000000fee1dead R15: 0000000000000000
|
|
Petr Mladek |
d34d07 |
FS: 00007f32bedf8980(0000) GS:ffff88801f480000(0000) knlGS:0000000000000000
|
|
Petr Mladek |
d34d07 |
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
|
|
Petr Mladek |
d34d07 |
CR2: ffffffff90ab1bb0 CR3: 000000001d057000 CR4: 00000000000006a0
|
|
Petr Mladek |
d34d07 |
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
|
|
Petr Mladek |
d34d07 |
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
|
|
Petr Mladek |
d34d07 |
Call Trace:
|
|
Petr Mladek |
d34d07 |
__do_sys_reboot.cold+0x34/0x5b
|
|
Petr Mladek |
d34d07 |
do_syscall_64+0x2d/0x40
|
|
Petr Mladek |
d34d07 |
|
|
Petr Mladek |
d34d07 |
Fixes: 1b3a5d02ee07 ("reboot: move arch/x86 reboot= handling to generic kernel")
|
|
Petr Mladek |
d34d07 |
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
|
|
Petr Mladek |
d34d07 |
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
|
|
Petr Mladek |
d34d07 |
Cc: Arnd Bergmann <arnd@arndb.de>
|
|
Petr Mladek |
d34d07 |
Cc: Fabian Frederick <fabf@skynet.be>
|
|
Petr Mladek |
d34d07 |
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Petr Mladek |
d34d07 |
Cc: Guenter Roeck <linux@roeck-us.net>
|
|
Petr Mladek |
d34d07 |
Cc: Kees Cook <keescook@chromium.org>
|
|
Petr Mladek |
d34d07 |
Cc: Mike Rapoport <rppt@kernel.org>
|
|
Petr Mladek |
d34d07 |
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
|
|
Petr Mladek |
d34d07 |
Cc: Petr Mladek <pmladek@suse.com>
|
|
Petr Mladek |
d34d07 |
Cc: Robin Holt <robinmholt@gmail.com>
|
|
Petr Mladek |
d34d07 |
Cc: <stable@vger.kernel.org>
|
|
Petr Mladek |
d34d07 |
Link: https://lkml.kernel.org/r/20201103214025.116799-3-mcroce@linux.microsoft.com
|
|
Petr Mladek |
d34d07 |
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
|
Petr Mladek |
d34d07 |
Acked-by: Petr Mladek <pmladek@suse.com>
|
|
Petr Mladek |
d34d07 |
|
|
Petr Mladek |
d34d07 |
---
|
|
Petr Mladek |
d34d07 |
kernel/reboot.c | 7 +++++++
|
|
Petr Mladek |
d34d07 |
1 file changed, 7 insertions(+)
|
|
Petr Mladek |
d34d07 |
|
|
Petr Mladek |
d34d07 |
--- a/kernel/reboot.c
|
|
Petr Mladek |
d34d07 |
+++ b/kernel/reboot.c
|
|
Petr Mladek |
d34d07 |
@@ -519,6 +519,13 @@ static int __init reboot_setup(char *str
|
|
Petr Mladek |
d34d07 |
reboot_cpu = simple_strtoul(str+3, NULL, 0);
|
|
Petr Mladek |
d34d07 |
else
|
|
Petr Mladek |
d34d07 |
reboot_mode = REBOOT_SOFT;
|
|
Petr Mladek |
d34d07 |
+ if (reboot_cpu >= num_possible_cpus()) {
|
|
Petr Mladek |
d34d07 |
+ pr_err("Ignoring the CPU number in reboot= option. "
|
|
Petr Mladek |
d34d07 |
+ "CPU %d exceeds possible cpu number %d\n",
|
|
Petr Mladek |
d34d07 |
+ reboot_cpu, num_possible_cpus());
|
|
Petr Mladek |
d34d07 |
+ reboot_cpu = 0;
|
|
Petr Mladek |
d34d07 |
+ break;
|
|
Petr Mladek |
d34d07 |
+ }
|
|
Petr Mladek |
d34d07 |
break;
|
|
Petr Mladek |
d34d07 |
|
|
Petr Mladek |
d34d07 |
case 'g':
|