From 31a6297b89aabc81b274c093a308a7f5b55081a7 Mon Sep 17 00:00:00 2001

From: Andreas Kemnade <andreas@kemnade.info>

Date: Sun, 20 Nov 2022 23:12:08 +0100

Subject: [PATCH] regulator: twl6030: fix get status of twl6032 regulators

Git-commit: 31a6297b89aabc81b274c093a308a7f5b55081a7

Patch-mainline: v6.1-rc7

References: git-fixes

Status is reported as always off in the 6032 case. Status

reporting now matches the logic in the setters. Once of

the differences to the 6030 is that there are no groups,

therefore the state needs to be read out in the lower bits.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Link: https://lore.kernel.org/r/20221120221208.3093727-3-andreas@kemnade.info

Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/regulator/twl6030-regulator.c | 15 +++++++++++----

 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/twl6030-regulator.c b/drivers/regulator/twl6030-regulator.c

index 7c7e3648ea4b..f3856750944f 100644

--- a/drivers/regulator/twl6030-regulator.c

+++ b/drivers/regulator/twl6030-regulator.c

@@ -67,6 +67,7 @@ struct twlreg_info {

 #define TWL6030_CFG_STATE_SLEEP	0x03

 #define TWL6030_CFG_STATE_GRP_SHIFT	5

 #define TWL6030_CFG_STATE_APP_SHIFT	2

+#define TWL6030_CFG_STATE_MASK		0x03

 #define TWL6030_CFG_STATE_APP_MASK	(0x03 << TWL6030_CFG_STATE_APP_SHIFT)

 #define TWL6030_CFG_STATE_APP(v)	(((v) & TWL6030_CFG_STATE_APP_MASK) >>\

 						TWL6030_CFG_STATE_APP_SHIFT)

@@ -128,13 +129,14 @@ static int twl6030reg_is_enabled(struct regulator_dev *rdev)

 		if (grp < 0)

 			return grp;

 		grp &= P1_GRP_6030;

+		val = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_STATE);

+		val = TWL6030_CFG_STATE_APP(val);

 	} else {

+		val = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_STATE);

+		val &= TWL6030_CFG_STATE_MASK;

 		grp = 1;

 	}

-	val = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_STATE);

-	val = TWL6030_CFG_STATE_APP(val);

-

 	return grp && (val == TWL6030_CFG_STATE_ON);

 }

@@ -187,7 +189,12 @@ static int twl6030reg_get_status(struct regulator_dev *rdev)

 	val = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_STATE);

-	switch (TWL6030_CFG_STATE_APP(val)) {

+	if (info->features & TWL6032_SUBCLASS)

+		val &= TWL6030_CFG_STATE_MASK;

+	else

+		val = TWL6030_CFG_STATE_APP(val);

+

+	switch (val) {

 	case TWL6030_CFG_STATE_ON:

 		return REGULATOR_STATUS_NORMAL;

-- 

2.35.3