Miroslav Franc 2831bb
From: Sebastian Ott <sebott@linux.ibm.com>
Miroslav Franc 2831bb
Date: Thu, 18 Oct 2018 11:11:08 +0200
Miroslav Franc 2831bb
Subject: s390/pci: fix sleeping in atomic during hotplug
Miroslav Franc 2831bb
Git-commit: 98dfd32620e970eb576ebce5ea39d905cb005e72
Miroslav Franc 2831bb
Patch-mainline: v5.0-rc1
Miroslav Franc 2831bb
References: git-fixes bsc#1211364
Miroslav Franc 2831bb
Miroslav Franc 2831bb
When triggered by pci hotplug (PEC 0x306) clp_get_state is called
Miroslav Franc 2831bb
with spinlocks held resulting in the following warning:
Miroslav Franc 2831bb
Miroslav Franc 2831bb
zpci: n/a: Event 0x306 reconfigured PCI function 0x0
Miroslav Franc 2831bb
BUG: sleeping function called from invalid context at mm/page_alloc.c:4324
Miroslav Franc 2831bb
in_atomic(): 1, irqs_disabled(): 0, pid: 98, name: kmcheck
Miroslav Franc 2831bb
2 locks held by kmcheck/98:
Miroslav Franc 2831bb
Miroslav Franc 2831bb
Change the allocation to use GFP_ATOMIC.
Miroslav Franc 2831bb
Miroslav Franc 2831bb
Cc: stable@vger.kernel.org # 4.13+
Miroslav Franc 2831bb
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Miroslav Franc 2831bb
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Miroslav Franc 2831bb
Acked-by: Miroslav Franc <mfranc@suse.cz>
Miroslav Franc 2831bb
---
Miroslav Franc 2831bb
 arch/s390/pci/pci_clp.c | 2 +-
Miroslav Franc 2831bb
 1 file changed, 1 insertion(+), 1 deletion(-)
Miroslav Franc 2831bb
Miroslav Franc 2831bb
diff --git a/arch/s390/pci/pci_clp.c b/arch/s390/pci/pci_clp.c
Miroslav Franc 2831bb
index 19b2d2a9b43d..eeb7450db18c 100644
Miroslav Franc 2831bb
--- a/arch/s390/pci/pci_clp.c
Miroslav Franc 2831bb
+++ b/arch/s390/pci/pci_clp.c
Miroslav Franc 2831bb
@@ -436,7 +436,7 @@ int clp_get_state(u32 fid, enum zpci_state *state)
Miroslav Franc 2831bb
 	struct clp_state_data sd = {fid, ZPCI_FN_STATE_RESERVED};
Miroslav Franc 2831bb
 	int rc;
Miroslav Franc 2831bb
 
Miroslav Franc 2831bb
-	rrb = clp_alloc_block(GFP_KERNEL);
Miroslav Franc 2831bb
+	rrb = clp_alloc_block(GFP_ATOMIC);
Miroslav Franc 2831bb
 	if (!rrb)
Miroslav Franc 2831bb
 		return -ENOMEM;
Miroslav Franc 2831bb
 
Miroslav Franc 2831bb