Blame patches.suse/s390-pci-removes-wrong-pci-multifunction-assignment
|
Petr Tesarik |
341ff3 |
From: Pierre Morel <pmorel@linux.ibm.com>
|
|
Petr Tesarik |
341ff3 |
Date: Tue, 28 Apr 2020 11:25:56 -0400
|
|
Petr Tesarik |
341ff3 |
Subject: s390/pci: removes wrong PCI multifunction assignment
|
|
Petr Tesarik |
341ff3 |
Git-commit: d1379279f2d6b407bd08324a170cb21928e69854
|
|
Petr Tesarik |
341ff3 |
Patch-mainline: v5.8-rc1
|
|
Petr Tesarik |
341ff3 |
References: jsc#SLE-13818 bsc#1177117 LTC#186574
|
|
Petr Tesarik |
341ff3 |
|
|
Petr Tesarik |
341ff3 |
The assignment of the PCI device multifunction attribute
|
|
Petr Tesarik |
341ff3 |
is set during the PCI device probe.
|
|
Petr Tesarik |
341ff3 |
There is no need to set it here.
|
|
Petr Tesarik |
341ff3 |
|
|
Petr Tesarik |
341ff3 |
Let's do it right and remove this assignment.
|
|
Petr Tesarik |
341ff3 |
|
|
Petr Tesarik |
341ff3 |
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
|
|
Petr Tesarik |
341ff3 |
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
|
|
Petr Tesarik |
341ff3 |
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
|
|
Petr Tesarik |
341ff3 |
Acked-by: Petr Tesarik <ptesarik@suse.com>
|
|
Petr Tesarik |
341ff3 |
---
|
|
Petr Tesarik |
341ff3 |
arch/s390/pci/pci_bus.c | 4 +---
|
|
Petr Tesarik |
341ff3 |
1 file changed, 1 insertion(+), 3 deletions(-)
|
|
Petr Tesarik |
341ff3 |
|
|
Petr Tesarik |
341ff3 |
--- a/arch/s390/pci/pci_bus.c
|
|
Petr Tesarik |
341ff3 |
+++ b/arch/s390/pci/pci_bus.c
|
|
Petr Tesarik |
341ff3 |
@@ -156,10 +156,8 @@ static int zpci_bus_add_device(struct zp
|
|
Petr Tesarik |
341ff3 |
}
|
|
Petr Tesarik |
341ff3 |
|
|
Petr Tesarik |
341ff3 |
pdev = pci_scan_single_device(bus, zdev->devfn);
|
|
Petr Tesarik |
341ff3 |
- if (pdev) {
|
|
Petr Tesarik |
341ff3 |
- pdev->multifunction = 1;
|
|
Petr Tesarik |
341ff3 |
+ if (pdev)
|
|
Petr Tesarik |
341ff3 |
pci_bus_add_device(pdev);
|
|
Petr Tesarik |
341ff3 |
- }
|
|
Petr Tesarik |
341ff3 |
|
|
Petr Tesarik |
341ff3 |
return 0;
|
|
Petr Tesarik |
341ff3 |
}
|