Joerg Roedel fa147c
From: Tony Krowiak <akrowiak@linux.ibm.com>
Joerg Roedel fa147c
Date: Tue, 10 Sep 2019 11:17:45 -0400
Joerg Roedel fa147c
Subject: s390/vfio-ap: sysfs attribute to display the guest's matrix
Joerg Roedel fa147c
Git-commit: f7f795c54d7117d06d002e06f9fca5baec3f293d
Joerg Roedel fa147c
Patch-mainline: v6.0-rc1
Joerg Roedel fa147c
References: bsc#1205701
Joerg Roedel fa147c
Joerg Roedel fa147c
The matrix of adapters and domains configured in a guest's APCB may
Joerg Roedel fa147c
differ from the matrix of adapters and domains assigned to the matrix mdev,
Joerg Roedel fa147c
so this patch introduces a sysfs attribute to display the matrix of
Joerg Roedel fa147c
adapters and domains that are or will be assigned to the APCB of a guest
Joerg Roedel fa147c
that is or will be using the matrix mdev. For a matrix mdev denoted by
Joerg Roedel fa147c
$uuid, the guest matrix can be displayed as follows:
Joerg Roedel fa147c
Joerg Roedel fa147c
   cat /sys/devices/vfio_ap/matrix/$uuid/guest_matrix
Joerg Roedel fa147c
Joerg Roedel fa147c
Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
Joerg Roedel fa147c
Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>
Joerg Roedel fa147c
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Joerg Roedel fa147c
Acked-by: Joerg Roedel <jroedel@suse.de>
Joerg Roedel fa147c
---
Joerg Roedel fa147c
 drivers/s390/crypto/vfio_ap_ops.c | 48 ++++++++++++++++++++++++++++-----------
Joerg Roedel fa147c
 1 file changed, 35 insertions(+), 13 deletions(-)
Joerg Roedel fa147c
Joerg Roedel fa147c
diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
Joerg Roedel fa147c
index 4a864fc5b788..6d722de44e8d 100644
Joerg Roedel fa147c
--- a/drivers/s390/crypto/vfio_ap_ops.c
Joerg Roedel fa147c
+++ b/drivers/s390/crypto/vfio_ap_ops.c
Joerg Roedel fa147c
@@ -1427,28 +1427,24 @@ static ssize_t control_domains_show(struct device *dev,
Joerg Roedel fa147c
 }
Joerg Roedel fa147c
 static DEVICE_ATTR_RO(control_domains);
Joerg Roedel fa147c
 
Joerg Roedel fa147c
-static ssize_t matrix_show(struct device *dev, struct device_attribute *attr,
Joerg Roedel fa147c
-			   char *buf)
Joerg Roedel fa147c
+static ssize_t vfio_ap_mdev_matrix_show(struct ap_matrix *matrix, char *buf)
Joerg Roedel fa147c
 {
Joerg Roedel fa147c
-	struct ap_matrix_mdev *matrix_mdev = dev_get_drvdata(dev);
Joerg Roedel fa147c
 	char *bufpos = buf;
Joerg Roedel fa147c
 	unsigned long apid;
Joerg Roedel fa147c
 	unsigned long apqi;
Joerg Roedel fa147c
 	unsigned long apid1;
Joerg Roedel fa147c
 	unsigned long apqi1;
Joerg Roedel fa147c
-	unsigned long napm_bits = matrix_mdev->matrix.apm_max + 1;
Joerg Roedel fa147c
-	unsigned long naqm_bits = matrix_mdev->matrix.aqm_max + 1;
Joerg Roedel fa147c
+	unsigned long napm_bits = matrix->apm_max + 1;
Joerg Roedel fa147c
+	unsigned long naqm_bits = matrix->aqm_max + 1;
Joerg Roedel fa147c
 	int nchars = 0;
Joerg Roedel fa147c
 	int n;
Joerg Roedel fa147c
 
Joerg Roedel fa147c
-	apid1 = find_first_bit_inv(matrix_mdev->matrix.apm, napm_bits);
Joerg Roedel fa147c
-	apqi1 = find_first_bit_inv(matrix_mdev->matrix.aqm, naqm_bits);
Joerg Roedel fa147c
-
Joerg Roedel fa147c
-	mutex_lock(&matrix_dev->mdevs_lock);
Joerg Roedel fa147c
+	apid1 = find_first_bit_inv(matrix->apm, napm_bits);
Joerg Roedel fa147c
+	apqi1 = find_first_bit_inv(matrix->aqm, naqm_bits);
Joerg Roedel fa147c
 
Joerg Roedel fa147c
 	if ((apid1 < napm_bits) && (apqi1 < naqm_bits)) {
Joerg Roedel fa147c
-		for_each_set_bit_inv(apid, matrix_mdev->matrix.apm, napm_bits) {
Joerg Roedel fa147c
-			for_each_set_bit_inv(apqi, matrix_mdev->matrix.aqm,
Joerg Roedel fa147c
+		for_each_set_bit_inv(apid, matrix->apm, napm_bits) {
Joerg Roedel fa147c
+			for_each_set_bit_inv(apqi, matrix->aqm,
Joerg Roedel fa147c
 					     naqm_bits) {
Joerg Roedel fa147c
 				n = sprintf(bufpos, "%02lx.%04lx\n", apid,
Joerg Roedel fa147c
 					    apqi);
Joerg Roedel fa147c
@@ -1457,25 +1453,50 @@ static ssize_t matrix_show(struct device *dev, struct device_attribute *attr,
Joerg Roedel fa147c
 			}
Joerg Roedel fa147c
 		}
Joerg Roedel fa147c
 	} else if (apid1 < napm_bits) {
Joerg Roedel fa147c
-		for_each_set_bit_inv(apid, matrix_mdev->matrix.apm, napm_bits) {
Joerg Roedel fa147c
+		for_each_set_bit_inv(apid, matrix->apm, napm_bits) {
Joerg Roedel fa147c
 			n = sprintf(bufpos, "%02lx.\n", apid);
Joerg Roedel fa147c
 			bufpos += n;
Joerg Roedel fa147c
 			nchars += n;
Joerg Roedel fa147c
 		}
Joerg Roedel fa147c
 	} else if (apqi1 < naqm_bits) {
Joerg Roedel fa147c
-		for_each_set_bit_inv(apqi, matrix_mdev->matrix.aqm, naqm_bits) {
Joerg Roedel fa147c
+		for_each_set_bit_inv(apqi, matrix->aqm, naqm_bits) {
Joerg Roedel fa147c
 			n = sprintf(bufpos, ".%04lx\n", apqi);
Joerg Roedel fa147c
 			bufpos += n;
Joerg Roedel fa147c
 			nchars += n;
Joerg Roedel fa147c
 		}
Joerg Roedel fa147c
 	}
Joerg Roedel fa147c
 
Joerg Roedel fa147c
+	return nchars;
Joerg Roedel fa147c
+}
Joerg Roedel fa147c
+
Joerg Roedel fa147c
+static ssize_t matrix_show(struct device *dev, struct device_attribute *attr,
Joerg Roedel fa147c
+			   char *buf)
Joerg Roedel fa147c
+{
Joerg Roedel fa147c
+	ssize_t nchars;
Joerg Roedel fa147c
+	struct ap_matrix_mdev *matrix_mdev = dev_get_drvdata(dev);
Joerg Roedel fa147c
+
Joerg Roedel fa147c
+	mutex_lock(&matrix_dev->mdevs_lock);
Joerg Roedel fa147c
+	nchars = vfio_ap_mdev_matrix_show(&matrix_mdev->matrix, buf);
Joerg Roedel fa147c
 	mutex_unlock(&matrix_dev->mdevs_lock);
Joerg Roedel fa147c
 
Joerg Roedel fa147c
 	return nchars;
Joerg Roedel fa147c
 }
Joerg Roedel fa147c
 static DEVICE_ATTR_RO(matrix);
Joerg Roedel fa147c
 
Joerg Roedel fa147c
+static ssize_t guest_matrix_show(struct device *dev,
Joerg Roedel fa147c
+				 struct device_attribute *attr, char *buf)
Joerg Roedel fa147c
+{
Joerg Roedel fa147c
+	ssize_t nchars;
Joerg Roedel fa147c
+	struct ap_matrix_mdev *matrix_mdev = dev_get_drvdata(dev);
Joerg Roedel fa147c
+
Joerg Roedel fa147c
+	mutex_lock(&matrix_dev->mdevs_lock);
Joerg Roedel fa147c
+	nchars = vfio_ap_mdev_matrix_show(&matrix_mdev->shadow_apcb, buf);
Joerg Roedel fa147c
+	mutex_unlock(&matrix_dev->mdevs_lock);
Joerg Roedel fa147c
+
Joerg Roedel fa147c
+	return nchars;
Joerg Roedel fa147c
+}
Joerg Roedel fa147c
+static DEVICE_ATTR_RO(guest_matrix);
Joerg Roedel fa147c
+
Joerg Roedel fa147c
 static struct attribute *vfio_ap_mdev_attrs[] = {
Joerg Roedel fa147c
 	&dev_attr_assign_adapter.attr,
Joerg Roedel fa147c
 	&dev_attr_unassign_adapter.attr,
Joerg Roedel fa147c
@@ -1485,6 +1506,7 @@ static struct attribute *vfio_ap_mdev_attrs[] = {
Joerg Roedel fa147c
 	&dev_attr_unassign_control_domain.attr,
Joerg Roedel fa147c
 	&dev_attr_control_domains.attr,
Joerg Roedel fa147c
 	&dev_attr_matrix.attr,
Joerg Roedel fa147c
+	&dev_attr_guest_matrix.attr,
Joerg Roedel fa147c
 	NULL,
Joerg Roedel fa147c
 };
Joerg Roedel fa147c
 
Joerg Roedel fa147c