|
Daniel Wagner |
996de9 |
From: James Smart <jsmart2021@gmail.com>
|
|
Daniel Wagner |
996de9 |
Date: Fri, 3 Jun 2022 10:43:24 -0700
|
|
Daniel Wagner |
996de9 |
Subject: scsi: lpfc: Address NULL pointer dereference after starget_to_rport()
|
|
Daniel Wagner |
996de9 |
Patch-mainline: v5.19-rc2
|
|
Daniel Wagner |
996de9 |
Git-commit: 6f808bd78e8296b4ded813b7182988d57e1f6176
|
|
Daniel Wagner |
996de9 |
References: git-fixes
|
|
Daniel Wagner |
996de9 |
|
|
Daniel Wagner |
996de9 |
Calls to starget_to_rport() may return NULL. Add check for NULL rport
|
|
Daniel Wagner |
996de9 |
before dereference.
|
|
Daniel Wagner |
996de9 |
|
|
Daniel Wagner |
996de9 |
Link: https://lore.kernel.org/r/20220603174329.63777-5-jsmart2021@gmail.com
|
|
Daniel Wagner |
996de9 |
Fixes: bb21fc9911ee ("scsi: lpfc: Use fc_block_rport()")
|
|
Daniel Wagner |
996de9 |
Cc: <stable@vger.kernel.org> # v5.18
|
|
Daniel Wagner |
996de9 |
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
|
|
Daniel Wagner |
996de9 |
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
|
|
Daniel Wagner |
996de9 |
Signed-off-by: James Smart <jsmart2021@gmail.com>
|
|
Daniel Wagner |
996de9 |
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
|
Daniel Wagner |
996de9 |
Acked-by: Daniel Wagner <dwagner@suse.de>
|
|
Daniel Wagner |
996de9 |
---
|
|
Daniel Wagner |
996de9 |
drivers/scsi/lpfc/lpfc_scsi.c | 6 ++++++
|
|
Daniel Wagner |
996de9 |
1 file changed, 6 insertions(+)
|
|
Daniel Wagner |
996de9 |
|
|
Daniel Wagner |
996de9 |
--- a/drivers/scsi/lpfc/lpfc_scsi.c
|
|
Daniel Wagner |
996de9 |
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
|
|
Daniel Wagner |
996de9 |
@@ -6065,6 +6065,9 @@ lpfc_device_reset_handler(struct scsi_cm
|
|
Daniel Wagner |
996de9 |
int status;
|
|
Daniel Wagner |
996de9 |
u32 logit = LOG_FCP;
|
|
Daniel Wagner |
996de9 |
|
|
Daniel Wagner |
996de9 |
+ if (!rport)
|
|
Daniel Wagner |
996de9 |
+ return FAILED;
|
|
Daniel Wagner |
996de9 |
+
|
|
Daniel Wagner |
996de9 |
rdata = rport->dd_data;
|
|
Daniel Wagner |
996de9 |
if (!rdata || !rdata->pnode) {
|
|
Daniel Wagner |
996de9 |
lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT,
|
|
Daniel Wagner |
996de9 |
@@ -6143,6 +6146,9 @@ lpfc_target_reset_handler(struct scsi_cm
|
|
Daniel Wagner |
996de9 |
unsigned long flags;
|
|
Daniel Wagner |
996de9 |
DECLARE_WAIT_QUEUE_HEAD_ONSTACK(waitq);
|
|
Daniel Wagner |
996de9 |
|
|
Daniel Wagner |
996de9 |
+ if (!rport)
|
|
Daniel Wagner |
996de9 |
+ return FAILED;
|
|
Daniel Wagner |
996de9 |
+
|
|
Daniel Wagner |
996de9 |
rdata = rport->dd_data;
|
|
Daniel Wagner |
996de9 |
if (!rdata || !rdata->pnode) {
|
|
Daniel Wagner |
996de9 |
lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT,
|