Daniel Wagner d6f3af
From: Quinn Tran <qutran@marvell.com>
Daniel Wagner d6f3af
Date: Tue, 12 Jul 2022 22:20:41 -0700
Daniel Wagner d6f3af
Subject: scsi: qla2xxx: Fix imbalance vha->vref_count
Denis Kirjanov 718367
Patch-mainline: v5.20-rc1
Daniel Wagner d6f3af
Git-commit: 63fa7f2644b4b48e1913af33092c044bf48e9321
Daniel Wagner d6f3af
References: bsc#1201651
Daniel Wagner d6f3af
Daniel Wagner d6f3af
vref_count took an extra decrement in the task management path.  Add an
Daniel Wagner d6f3af
extra ref count to compensate the imbalance.
Daniel Wagner d6f3af
Daniel Wagner d6f3af
Link: https://lore.kernel.org/r/20220713052045.10683-7-njavali@marvell.com
Daniel Wagner d6f3af
Cc: stable@vger.kernel.org
Daniel Wagner d6f3af
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Daniel Wagner d6f3af
Signed-off-by: Quinn Tran <qutran@marvell.com>
Daniel Wagner d6f3af
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Daniel Wagner d6f3af
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Daniel Wagner d6f3af
Acked-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner d6f3af
---
Daniel Wagner d6f3af
 drivers/scsi/qla2xxx/qla_init.c |    4 ++++
Daniel Wagner d6f3af
 1 file changed, 4 insertions(+)
Daniel Wagner d6f3af
Daniel Wagner d6f3af
--- a/drivers/scsi/qla2xxx/qla_init.c
Daniel Wagner d6f3af
+++ b/drivers/scsi/qla2xxx/qla_init.c
Daniel Wagner d6f3af
@@ -162,6 +162,7 @@ int qla24xx_async_abort_cmd(srb_t *cmd_s
Daniel Wagner d6f3af
 	struct srb_iocb *abt_iocb;
Daniel Wagner d6f3af
 	srb_t *sp;
Daniel Wagner d6f3af
 	int rval = QLA_FUNCTION_FAILED;
Daniel Wagner d6f3af
+	uint8_t bail;
Daniel Wagner d6f3af
 
Daniel Wagner d6f3af
 	/* ref: INIT for ABTS command */
Daniel Wagner d6f3af
 	sp = qla2xxx_get_qpair_sp(cmd_sp->vha, cmd_sp->qpair, cmd_sp->fcport,
Daniel Wagner d6f3af
@@ -169,6 +170,7 @@ int qla24xx_async_abort_cmd(srb_t *cmd_s
Daniel Wagner d6f3af
 	if (!sp)
Daniel Wagner d6f3af
 		return QLA_MEMORY_ALLOC_FAILED;
Daniel Wagner d6f3af
 
Daniel Wagner d6f3af
+	QLA_VHA_MARK_BUSY(vha, bail);
Daniel Wagner d6f3af
 	abt_iocb = &sp->u.iocb_cmd;
Daniel Wagner d6f3af
 	sp->type = SRB_ABT_CMD;
Daniel Wagner d6f3af
 	sp->name = "abort";
Daniel Wagner d6f3af
@@ -2003,12 +2005,14 @@ qla2x00_async_tm_cmd(fc_port_t *fcport,
Daniel Wagner d6f3af
 	struct srb_iocb *tm_iocb;
Daniel Wagner d6f3af
 	srb_t *sp;
Daniel Wagner d6f3af
 	int rval = QLA_FUNCTION_FAILED;
Daniel Wagner d6f3af
+	uint8_t bail;
Daniel Wagner d6f3af
 
Daniel Wagner d6f3af
 	/* ref: INIT */
Daniel Wagner d6f3af
 	sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
Daniel Wagner d6f3af
 	if (!sp)
Daniel Wagner d6f3af
 		goto done;
Daniel Wagner d6f3af
 
Daniel Wagner d6f3af
+	QLA_VHA_MARK_BUSY(vha, bail);
Daniel Wagner d6f3af
 	sp->type = SRB_TM_CMD;
Daniel Wagner d6f3af
 	sp->name = "tmf";
Daniel Wagner d6f3af
 	qla2x00_init_async_sp(sp, qla2x00_get_async_timeout(vha),