Daniel Wagner 394000
From: Bikash Hazarika <bhazarika@marvell.com>
Daniel Wagner 394000
Date: Tue, 12 Jul 2022 22:20:38 -0700
Daniel Wagner 394000
Subject: scsi: qla2xxx: Zero undefined mailbox IN registers
Denis Kirjanov 718367
Patch-mainline: v5.20-rc1
Daniel Wagner 394000
Git-commit: 6c96a3c7d49593ef15805f5e497601c87695abc9
Daniel Wagner 394000
References: bsc#1201651
Daniel Wagner 394000
Daniel Wagner 394000
While requesting a new mailbox command, driver does not write any data to
Daniel Wagner 394000
unused registers.  Initialize the unused register value to zero while
Daniel Wagner 394000
requesting a new mailbox command to prevent stale entry access by firmware.
Daniel Wagner 394000
Daniel Wagner 394000
Link: https://lore.kernel.org/r/20220713052045.10683-4-njavali@marvell.com
Daniel Wagner 394000
Cc: stable@vger.kernel.org
Daniel Wagner 394000
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Daniel Wagner 394000
Signed-off-by: Bikash Hazarika <bhazarika@marvell.com>
Daniel Wagner 394000
Signed-off-by: Quinn Tran <qutran@marvell.com>
Daniel Wagner 394000
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Daniel Wagner 394000
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Daniel Wagner 394000
Acked-by: Daniel Wagner <dwagner@suse.de>
Daniel Wagner 394000
---
Daniel Wagner 394000
 drivers/scsi/qla2xxx/qla_mbx.c |    2 ++
Daniel Wagner 394000
 1 file changed, 2 insertions(+)
Daniel Wagner 394000
Daniel Wagner 394000
--- a/drivers/scsi/qla2xxx/qla_mbx.c
Daniel Wagner 394000
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
Daniel Wagner 394000
@@ -239,6 +239,8 @@ qla2x00_mailbox_command(scsi_qla_host_t
Daniel Wagner 394000
 			ql_dbg(ql_dbg_mbx, vha, 0x1112,
Daniel Wagner 394000
 			    "mbox[%d]<-0x%04x\n", cnt, *iptr);
Daniel Wagner 394000
 			wrt_reg_word(optr, *iptr);
Daniel Wagner 394000
+		} else {
Daniel Wagner 394000
+			wrt_reg_word(optr, 0);
Daniel Wagner 394000
 		}
Daniel Wagner 394000
 
Daniel Wagner 394000
 		mboxes >>= 1;