|
Daniel Wagner |
e5087a |
From: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Daniel Wagner |
e5087a |
Date: Tue, 9 Nov 2021 14:52:19 +0300
|
|
Daniel Wagner |
e5087a |
Subject: scsi: qla2xxx: edif: Fix off by one bug in qla_edif_app_getfcinfo()
|
|
Daniel Wagner |
e5087a |
Patch-mainline: v5.16-rc3
|
|
Daniel Wagner |
e5087a |
Git-commit: e11e285b9cd132db21568b5d29c291f590841944
|
|
Daniel Wagner |
e5087a |
References: git-fixes
|
|
Daniel Wagner |
e5087a |
|
|
Daniel Wagner |
e5087a |
The > comparison needs to be >= to prevent accessing one element beyond the
|
|
Daniel Wagner |
e5087a |
end of the app_reply->ports[] array.
|
|
Daniel Wagner |
e5087a |
|
|
Daniel Wagner |
e5087a |
Link: https://lore.kernel.org/r/20211109115219.GE16587@kili
|
|
Daniel Wagner |
e5087a |
Fixes: 7878f22a2e03 ("scsi: qla2xxx: edif: Add getfcinfo and statistic bsgs")
|
|
Daniel Wagner |
e5087a |
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
|
|
Daniel Wagner |
e5087a |
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
|
|
Daniel Wagner |
e5087a |
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Daniel Wagner |
e5087a |
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
|
Daniel Wagner |
e5087a |
Acked-by: Daniel Wagner <dwagner@suse.de>
|
|
Daniel Wagner |
e5087a |
---
|
|
Daniel Wagner |
e5087a |
drivers/scsi/qla2xxx/qla_edif.c | 2 +-
|
|
Daniel Wagner |
e5087a |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
Daniel Wagner |
e5087a |
|
|
Daniel Wagner |
e5087a |
--- a/drivers/scsi/qla2xxx/qla_edif.c
|
|
Daniel Wagner |
e5087a |
+++ b/drivers/scsi/qla2xxx/qla_edif.c
|
|
Daniel Wagner |
e5087a |
@@ -865,7 +865,7 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *
|
|
Daniel Wagner |
e5087a |
"APP request entry - portid=%06x.\n", tdid.b24);
|
|
Daniel Wagner |
e5087a |
|
|
Daniel Wagner |
e5087a |
/* Ran out of space */
|
|
Daniel Wagner |
e5087a |
- if (pcnt > app_req.num_ports)
|
|
Daniel Wagner |
e5087a |
+ if (pcnt >= app_req.num_ports)
|
|
Daniel Wagner |
e5087a |
break;
|
|
Daniel Wagner |
e5087a |
|
|
Daniel Wagner |
e5087a |
if (tdid.b24 != 0 && tdid.b24 != fcport->d_id.b24)
|