From: Quinn Tran <qutran@marvell.com>

Date: Wed, 8 Jun 2022 04:58:41 -0700

Subject: scsi: qla2xxx: edif: Send LOGO for unexpected IKE message

Patch-mainline: v5.20-rc1

Git-commit: 2b659ed67a12f39f56d8dcad9b5d5a74d67c01b3

References: bsc#1201958

If the session is down and the local port continues to receive AUTH ELS

messages, the driver needs to send back LOGO so that the remote device

knows to tear down its session. Terminate and clean up the AUTH ELS

exchange followed by a passthrough LOGO.

Link: https://lore.kernel.org/r/20220608115849.16693-3-njavali@marvell.com

Fixes: 225479296c4f ("scsi: qla2xxx: edif: Reject AUTH ELS on session down")

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

Signed-off-by: Quinn Tran <qutran@marvell.com>

Signed-off-by: Nilesh Javali <njavali@marvell.com>

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

Acked-by: Daniel Wagner <dwagner@suse.de>

---

 drivers/scsi/qla2xxx/qla_edif.c |   19 +++++++++++++++++--

 drivers/scsi/qla2xxx/qla_fw.h   |    2 +-

 2 files changed, 18 insertions(+), 3 deletions(-)

--- a/drivers/scsi/qla2xxx/qla_edif.c

+++ b/drivers/scsi/qla2xxx/qla_edif.c

@@ -2565,8 +2565,7 @@ void qla24xx_auth_els(scsi_qla_host_t *v

 	fcport = qla2x00_find_fcport_by_pid(host, &purex->pur_info.pur_sid);

-	if (DBELL_INACTIVE(vha) ||

-	    (fcport && EDIF_SESSION_DOWN(fcport))) {

+	if (DBELL_INACTIVE(vha)) {

 		ql_dbg(ql_dbg_edif, host, 0x0910c, "%s e_dbell.db_flags =%x %06x\n",

 		    __func__, host->e_dbell.db_flags,

 		    fcport ? fcport->d_id.b24 : 0);

@@ -2576,6 +2575,22 @@ void qla24xx_auth_els(scsi_qla_host_t *v

 		return;

 	}

+	if (fcport && EDIF_SESSION_DOWN(fcport)) {

+		ql_dbg(ql_dbg_edif, host, 0x13b6,

+		    "%s terminate exchange. Send logo to 0x%x\n",

+		    __func__, a.did.b24);

+

+		a.tx_byte_count = a.tx_len = 0;

+		a.tx_addr = 0;

+		a.control_flags = EPD_RX_XCHG;  /* EPD_RX_XCHG = terminate cmd */

+		qla_els_reject_iocb(host, (*rsp)->qpair, &a);

+		qla_enode_free(host, ptr);

+		/* send logo to let remote port knows to tear down session */

+		fcport->send_els_logo = 1;

+		qlt_schedule_sess_for_deletion(fcport);

+		return;

+	}

+

 	/* add the local enode to the list */

 	qla_enode_add(host, ptr);

--- a/drivers/scsi/qla2xxx/qla_fw.h

+++ b/drivers/scsi/qla2xxx/qla_fw.h

@@ -808,7 +808,7 @@ struct els_entry_24xx {

 #define EPD_ELS_COMMAND		(0 << 13)

 #define EPD_ELS_ACC		(1 << 13)

 #define EPD_ELS_RJT		(2 << 13)

-#define EPD_RX_XCHG		(3 << 13)

+#define EPD_RX_XCHG		(3 << 13)  /* terminate exchange */

 #define ECF_CLR_PASSTHRU_PEND	BIT_12

 #define ECF_INCL_FRAME_HDR	BIT_11

 #define ECF_SEC_LOGIN		BIT_3