From f264f2f6f4788dc031cef60a0cf2881902736709 Mon Sep 17 00:00:00 2001

From: Doug Berger <opendmb@gmail.com>

Date: Thu, 27 Apr 2023 11:19:16 -0700

Subject: [PATCH] serial: 8250_bcm7271: fix leak in `brcmuart_probe`

Git-commit: f264f2f6f4788dc031cef60a0cf2881902736709

Patch-mainline: 6.4-rc3

References: git-fixes

Smatch reports:

drivers/tty/serial/8250/8250_bcm7271.c:1120 brcmuart_probe() warn:

'baud_mux_clk' from clk_prepare_enable() not released on lines: 1032.

The issue is fixed by using a managed clock.

Fixes: 41a469482de2 ("serial: 8250: Add new 8250-core based Broadcom STB driver")

Reported-by: XuDong Liu <m202071377@hust.edu.cn>

Link: https://lore.kernel.org/lkml/20230424125100.4783-1-m202071377@hust.edu.cn/

Signed-off-by: Doug Berger <opendmb@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Link: https://lore.kernel.org/r/20230427181916.2983697-3-opendmb@gmail.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/tty/serial/8250/8250_bcm7271.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c

index 90ee7bc12f77..af0e1c070187 100644

--- a/drivers/tty/serial/8250/8250_bcm7271.c

+++ b/drivers/tty/serial/8250/8250_bcm7271.c

@@ -1012,7 +1012,7 @@ static int brcmuart_probe(struct platform_device *pdev)

 	of_property_read_u32(np, "clock-frequency", &clk_rate);

 	/* See if a Baud clock has been specified */

-	baud_mux_clk = of_clk_get_by_name(np, "sw_baud");

+	baud_mux_clk = devm_clk_get(dev, "sw_baud");

 	if (IS_ERR(baud_mux_clk)) {

 		if (PTR_ERR(baud_mux_clk) == -EPROBE_DEFER) {

 			ret = -EPROBE_DEFER;

-- 

2.35.3