From e0112a7c9e847ada15a631b88e279d547e8f26a7 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <dan.carpenter@oracle.com>

Date: Wed, 19 May 2021 17:16:50 +0300

Subject: [PATCH] staging: emxx_udc: fix loop in _nbu2ss_nuke()

Git-commit: e0112a7c9e847ada15a631b88e279d547e8f26a7

Patch-mainline: v5.13-rc4

References: git-fixes

The _nbu2ss_ep_done() function calls:

	list_del_init(&req->queue);

which means that the loop will never exit.

Fixes: ca3d253eb967 ("Staging: emxx_udc: Iterate list using list_for_each_entry")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Link: https://lore.kernel.org/r/YKUd0sDyjm/lkJfJ@mwanda

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/staging/emxx_udc/emxx_udc.c | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c

index 741147a4f0fe..ecc5c9da9027 100644

--- a/drivers/staging/emxx_udc/emxx_udc.c

+++ b/drivers/staging/emxx_udc/emxx_udc.c

@@ -2064,7 +2064,7 @@ static int _nbu2ss_nuke(struct nbu2ss_udc *udc,

 			struct nbu2ss_ep *ep,

 			int status)

 {

-	struct nbu2ss_req *req;

+	struct nbu2ss_req *req, *n;

 	/* Endpoint Disable */

 	_nbu2ss_epn_exit(udc, ep);

@@ -2076,7 +2076,7 @@ static int _nbu2ss_nuke(struct nbu2ss_udc *udc,

 		return 0;

 	/* called with irqs blocked */

-	list_for_each_entry(req, &ep->queue, queue) {

+	list_for_each_entry_safe(req, n, &ep->queue, queue) {

 		_nbu2ss_ep_done(ep, req, status);

 	}

-- 

2.26.2