Jiri Slaby e6e114
From: Eric Dumazet <edumazet@google.com>
Jiri Slaby e6e114
Date: Fri, 15 Sep 2017 16:47:42 -0700
Jiri Slaby e6e114
Subject: tcp: fix data delivery rate
Jiri Slaby e6e114
Git-commit: fc22579917eb7e13433448a342f1cb1592920940
Jiri Slaby e6e114
Patch-mainline: v4.14-rc1
Jiri Slaby e6e114
References: networking-stable-17_10_09
Jiri Slaby e6e114
Jiri Slaby e6e114
Now skb->mstamp_skb is updated later, we also need to call
Jiri Slaby e6e114
tcp_rate_skb_sent() after the update is done.
Jiri Slaby e6e114
Jiri Slaby e6e114
Fixes: 8c72c65b426b ("tcp: update skb->skb_mstamp more carefully")
Jiri Slaby e6e114
Signed-off-by: Eric Dumazet <edumazet@google.com>
Jiri Slaby e6e114
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Jiri Slaby e6e114
Signed-off-by: David S. Miller <davem@davemloft.net>
Jiri Slaby e6e114
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri Slaby e6e114
---
Jiri Slaby e6e114
 net/ipv4/tcp_output.c | 7 +++----
Jiri Slaby e6e114
 1 file changed, 3 insertions(+), 4 deletions(-)
Jiri Slaby e6e114
Jiri Slaby e6e114
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
Jiri Slaby e6e114
index a85a8c2948e5..1c839c99114c 100644
Jiri Slaby e6e114
--- a/net/ipv4/tcp_output.c
Jiri Slaby e6e114
+++ b/net/ipv4/tcp_output.c
Jiri Slaby e6e114
@@ -1002,8 +1002,6 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
Jiri Slaby e6e114
 	if (clone_it) {
Jiri Slaby e6e114
 		TCP_SKB_CB(skb)->tx.in_flight = TCP_SKB_CB(skb)->end_seq
Jiri Slaby e6e114
 			- tp->snd_una;
Jiri Slaby e6e114
-		tcp_rate_skb_sent(sk, skb);
Jiri Slaby e6e114
-
Jiri Slaby e6e114
 		oskb = skb;
Jiri Slaby e6e114
 		if (unlikely(skb_cloned(skb)))
Jiri Slaby e6e114
 			skb = pskb_copy(skb, gfp_mask);
Jiri Slaby e6e114
@@ -1128,9 +1126,10 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
Jiri Slaby e6e114
 		tcp_enter_cwr(sk);
Jiri Slaby e6e114
 		err = net_xmit_eval(err);
Jiri Slaby e6e114
 	}
Jiri Slaby e6e114
-	if (!err && oskb)
Jiri Slaby e6e114
+	if (!err && oskb) {
Jiri Slaby e6e114
 		oskb->skb_mstamp = tp->tcp_mstamp;
Jiri Slaby e6e114
-
Jiri Slaby e6e114
+		tcp_rate_skb_sent(sk, oskb);
Jiri Slaby e6e114
+	}
Jiri Slaby e6e114
 	return err;
Jiri Slaby e6e114
 }
Jiri Slaby e6e114
 
Jiri Slaby e6e114
-- 
Jiri Slaby e6e114
2.17.1
Jiri Slaby e6e114