Michal Suchanek af1fec
From e8cf229ebe5eb31eecee86268223530a872872c2 Mon Sep 17 00:00:00 2001
Michal Suchanek af1fec
From: Dan Williams <dan.j.williams@intel.com>
Michal Suchanek af1fec
Date: Sun, 3 Apr 2022 20:19:46 -0700
Michal Suchanek af1fec
Subject: [PATCH] tools/testing/nvdimm: Fix security_init() symbol collision
Michal Suchanek af1fec
MIME-Version: 1.0
Michal Suchanek af1fec
Content-Type: text/plain; charset=UTF-8
Michal Suchanek af1fec
Content-Transfer-Encoding: 8bit
Michal Suchanek af1fec
Michal Suchanek af1fec
References: jsc#PED-1925
Michal Suchanek af1fec
Patch-mainline: v5.18-rc2
Michal Suchanek af1fec
Git-commit: e8cf229ebe5eb31eecee86268223530a872872c2
Michal Suchanek af1fec
Michal Suchanek af1fec
Starting with the new perf-event support in the nvdimm core, the
Michal Suchanek af1fec
nfit_test mock module stops compiling. Rename its security_init() to
Michal Suchanek af1fec
nfit_security_init().
Michal Suchanek af1fec
Michal Suchanek af1fec
tools/testing/nvdimm/test/nfit.c:1845:13: error: conflicting types for ‘security_init’; have ‘void(struct nfit_test *)’
Michal Suchanek af1fec
 1845 | static void security_init(struct nfit_test *t)
Michal Suchanek af1fec
      |             ^~~~~~~~~~~~~
Michal Suchanek af1fec
In file included from ./include/linux/perf_event.h:61,
Michal Suchanek af1fec
                 from ./include/linux/nd.h:11,
Michal Suchanek af1fec
                 from ./drivers/nvdimm/nd-core.h:11,
Michal Suchanek af1fec
                 from tools/testing/nvdimm/test/nfit.c:19:
Michal Suchanek af1fec
Michal Suchanek af1fec
Fixes: 9a61d0838cd0 ("drivers/nvdimm: Add nvdimm pmu structure")
Michal Suchanek af1fec
Cc: Kajol Jain <kjain@linux.ibm.com>
Michal Suchanek af1fec
Reviewed-by: Kajol Jain <kjain@linux.ibm.com>
Michal Suchanek af1fec
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Michal Suchanek af1fec
Link: https://lore.kernel.org/r/164904238610.1330275.1889212115373993727.stgit@dwillia2-desk3.amr.corp.intel.com
Michal Suchanek af1fec
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Michal Suchanek af1fec
Acked-by: Michal Suchanek <msuchanek@suse.de>
Michal Suchanek af1fec
---
Michal Suchanek af1fec
 tools/testing/nvdimm/test/nfit.c | 4 ++--
Michal Suchanek af1fec
 1 file changed, 2 insertions(+), 2 deletions(-)
Michal Suchanek af1fec
Michal Suchanek af1fec
diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
Michal Suchanek af1fec
index 65dbdda3a054..1da76ccde448 100644
Michal Suchanek af1fec
--- a/tools/testing/nvdimm/test/nfit.c
Michal Suchanek af1fec
+++ b/tools/testing/nvdimm/test/nfit.c
Michal Suchanek af1fec
@@ -1842,7 +1842,7 @@ static int nfit_test_dimm_init(struct nfit_test *t)
Michal Suchanek af1fec
 	return 0;
Michal Suchanek af1fec
 }
Michal Suchanek af1fec
 
Michal Suchanek af1fec
-static void security_init(struct nfit_test *t)
Michal Suchanek af1fec
+static void nfit_security_init(struct nfit_test *t)
Michal Suchanek af1fec
 {
Michal Suchanek af1fec
 	int i;
Michal Suchanek af1fec
 
Michal Suchanek af1fec
@@ -1938,7 +1938,7 @@ static int nfit_test0_alloc(struct nfit_test *t)
Michal Suchanek af1fec
 	if (nfit_test_dimm_init(t))
Michal Suchanek af1fec
 		return -ENOMEM;
Michal Suchanek af1fec
 	smart_init(t);
Michal Suchanek af1fec
-	security_init(t);
Michal Suchanek af1fec
+	nfit_security_init(t);
Michal Suchanek af1fec
 	return ars_state_init(&t->pdev.dev, &t->ars_state);
Michal Suchanek af1fec
 }
Michal Suchanek af1fec
 
Michal Suchanek af1fec
-- 
Michal Suchanek af1fec
2.35.3
Michal Suchanek af1fec