Juergen Gross 5a7e7d
Patch-mainline: v6.2-rc3
Juergen Gross 5a7e7d
Git-commit: c262f75cb6bb5a63828e72ce3b8fe808e5029479
Juergen Gross 5a7e7d
References: git-fixes
Juergen Gross 5a7e7d
From: =?UTF-8?q?Ricardo=20Ca=C3=B1uelo?= <ricardo.canuelo@collabora.com>
Juergen Gross 5a7e7d
Date: Wed, 12 Oct 2022 08:29:49 +0200
Juergen Gross 5a7e7d
Subject: [PATCH] tools/virtio: initialize spinlocks in vring_test.c
Juergen Gross 5a7e7d
MIME-Version: 1.0
Juergen Gross 5a7e7d
Content-Type: text/plain; charset=UTF-8
Juergen Gross 5a7e7d
Content-Transfer-Encoding: 8bit
Juergen Gross 5a7e7d
Juergen Gross 5a7e7d
The virtio_device vqs_list spinlocks must be initialized before use to
Juergen Gross 5a7e7d
prevent functions that manipulate the device virtualqueues, such as
Juergen Gross 5a7e7d
vring_new_virtqueue(), from blocking indefinitely.
Juergen Gross 5a7e7d
Juergen Gross 5a7e7d
Signed-off-by: Ricardo CaƱuelo <ricardo.canuelo@collabora.com>
Juergen Gross 5a7e7d
Message-Id: <20221012062949.1526176-1-ricardo.canuelo@collabora.com>
Juergen Gross 5a7e7d
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Juergen Gross 5a7e7d
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Juergen Gross 5a7e7d
Signed-off-by: Juergen Gross <jgross@suse.com>
Juergen Gross 5a7e7d
---
Juergen Gross 5a7e7d
 tools/virtio/vringh_test.c | 2 ++
Juergen Gross 5a7e7d
 1 file changed, 2 insertions(+)
Juergen Gross 5a7e7d
Juergen Gross 5a7e7d
diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
Juergen Gross 5a7e7d
index fa87b58bd5fa..98ff808d6f0c 100644
Juergen Gross 5a7e7d
--- a/tools/virtio/vringh_test.c
Juergen Gross 5a7e7d
+++ b/tools/virtio/vringh_test.c
Juergen Gross 5a7e7d
@@ -308,6 +308,7 @@ static int parallel_test(u64 features,
Juergen Gross 5a7e7d
 
Juergen Gross 5a7e7d
 		gvdev.vdev.features = features;
Juergen Gross 5a7e7d
 		INIT_LIST_HEAD(&gvdev.vdev.vqs);
Juergen Gross 5a7e7d
+		spin_lock_init(&gvdev.vdev.vqs_list_lock);
Juergen Gross 5a7e7d
 		gvdev.to_host_fd = to_host[1];
Juergen Gross 5a7e7d
 		gvdev.notifies = 0;
Juergen Gross 5a7e7d
 
Juergen Gross 5a7e7d
@@ -455,6 +456,7 @@ int main(int argc, char *argv[])
Juergen Gross 5a7e7d
 	getrange = getrange_iov;
Juergen Gross 5a7e7d
 	vdev.features = 0;
Juergen Gross 5a7e7d
 	INIT_LIST_HEAD(&vdev.vqs);
Juergen Gross 5a7e7d
+	spin_lock_init(&vdev.vqs_list_lock);
Juergen Gross 5a7e7d
 
Juergen Gross 5a7e7d
 	while (argv[1]) {
Juergen Gross 5a7e7d
 		if (strcmp(argv[1], "--indirect") == 0)
Juergen Gross 5a7e7d
-- 
Juergen Gross 5a7e7d
2.35.3
Juergen Gross 5a7e7d