From: Xiaoke Wang <xkernel.wang@foxmail.com>

Date: Tue, 14 Dec 2021 09:28:02 +0800

Subject: tracing/uprobes: Check the return value of kstrdup() for tu->filename

Git-commit: 8c7224245557707c613f130431cafbaaa4889615

Patch-mainline: v5.16 or v5.16-rc9 (next release)

References: git-fixes

kstrdup() returns NULL when some internal memory errors happen, it is

better to check the return value of it so to catch the memory error in

time.

Link: https://lkml.kernel.org/r/tencent_3C2E330722056D7891D2C83F29C802734B06@qq.com

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Fixes: 33ea4b24277b ("perf/core: Implement the 'perf_uprobe' PMU")

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Acked-by: Miroslav Benes <mbenes@suse.cz>

---

 kernel/trace/trace_uprobe.c |    5 +++++

 1 file changed, 5 insertions(+)

--- a/kernel/trace/trace_uprobe.c

+++ b/kernel/trace/trace_uprobe.c

@@ -1389,6 +1389,11 @@ create_local_trace_uprobe(char *name, un

 	tu->path = path;

 	tu->ref_ctr_offset = ref_ctr_offset;

 	tu->filename = kstrdup(name, GFP_KERNEL);

+	if (!tu->filename) {

+		ret = -ENOMEM;

+		goto error;

+	}

+

 	init_trace_event_call(tu);

 	if (traceprobe_set_print_fmt(&tu->tp, is_ret_probe(tu)) < 0) {