Takashi Iwai 243a64
From 1cd17f7f0def31e3695501c4f86cd3faf8489840 Mon Sep 17 00:00:00 2001
Takashi Iwai 243a64
From: Emiliano Ingrassia <ingrassia@epigenesys.com>
Takashi Iwai 243a64
Date: Wed, 27 Nov 2019 17:03:55 +0100
Takashi Iwai 243a64
Subject: [PATCH] usb: core: urb: fix URB structure initialization function
Takashi Iwai 243a64
Git-commit: 1cd17f7f0def31e3695501c4f86cd3faf8489840
Takashi Iwai 243a64
Patch-mainline: v5.5-rc2
Takashi Iwai 243a64
References: bsc#1051510
Takashi Iwai 243a64
Takashi Iwai 243a64
Explicitly initialize URB structure urb_list field in usb_init_urb().
Takashi Iwai 243a64
This field can be potentially accessed uninitialized and its
Takashi Iwai 243a64
initialization is coherent with the usage of list_del_init() in
Takashi Iwai 243a64
usb_hcd_unlink_urb_from_ep() and usb_giveback_urb_bh() and its
Takashi Iwai 243a64
explicit initialization in usb_hcd_submit_urb() error path.
Takashi Iwai 243a64
Takashi Iwai 243a64
Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
Takashi Iwai 243a64
Cc: stable <stable@vger.kernel.org>
Takashi Iwai 243a64
Link: https://lore.kernel.org/r/20191127160355.GA27196@ingrassia.epigenesys.com
Takashi Iwai 243a64
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Takashi Iwai 243a64
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 243a64
Takashi Iwai 243a64
---
Takashi Iwai 243a64
 drivers/usb/core/urb.c | 1 +
Takashi Iwai 243a64
 1 file changed, 1 insertion(+)
Takashi Iwai 243a64
Takashi Iwai 243a64
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
Takashi Iwai 243a64
index 0eab79f82ce4..da923ec17612 100644
Takashi Iwai 243a64
--- a/drivers/usb/core/urb.c
Takashi Iwai 243a64
+++ b/drivers/usb/core/urb.c
Takashi Iwai 243a64
@@ -45,6 +45,7 @@ void usb_init_urb(struct urb *urb)
Takashi Iwai 243a64
 	if (urb) {
Takashi Iwai 243a64
 		memset(urb, 0, sizeof(*urb));
Takashi Iwai 243a64
 		kref_init(&urb->kref);
Takashi Iwai 243a64
+		INIT_LIST_HEAD(&urb->urb_list);
Takashi Iwai 243a64
 		INIT_LIST_HEAD(&urb->anchor_list);
Takashi Iwai 243a64
 	}
Takashi Iwai 243a64
 }
Takashi Iwai 243a64
-- 
Takashi Iwai 243a64
2.16.4
Takashi Iwai 243a64