From f28ad9069363dec7deb88032b70612755eed9ee6 Mon Sep 17 00:00:00 2001

From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Date: Mon, 11 Apr 2022 18:33:47 -0700

Subject: [PATCH] usb: dwc3: core: Fix tx/rx threshold settings

Git-commit: f28ad9069363dec7deb88032b70612755eed9ee6

References: git-fixes

Patch-mainline: v5.18-rc5

The current driver logic checks against 0 to determine whether the

periodic tx/rx threshold settings are set, but we may get bogus values

from uninitialized variables if no device property is set. Properly

default these variables to 0.

Fixes: 938a5ad1d305 ("usb: dwc3: Check for ESS TX/RX threshold config")

Cc: <stable@vger.kernel.org>

Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Link: https://lore.kernel.org/r/cccfce990b11b730b0dae42f9d217dc6fb988c90.1649727139.git.Thinh.Nguyen@synopsys.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Oliver Neukum <oneukum@suse.com>

---

 drivers/usb/dwc3/core.c |    8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/usb/dwc3/core.c

+++ b/drivers/usb/dwc3/core.c

@@ -1256,10 +1256,10 @@ static void dwc3_get_properties(struct d

 	u8			lpm_nyet_threshold;

 	u8			tx_de_emphasis;

 	u8			hird_threshold;

-	u8			rx_thr_num_pkt_prd;

-	u8			rx_max_burst_prd;

-	u8			tx_thr_num_pkt_prd;

-	u8			tx_max_burst_prd;

+	u8			rx_thr_num_pkt_prd = 0;

+	u8			rx_max_burst_prd = 0;

+	u8			tx_thr_num_pkt_prd = 0;

+	u8			tx_max_burst_prd = 0;

 	/* default to highest possible threshold */

 	lpm_nyet_threshold = 0xf;