Takashi Iwai c0b42c
From 408d3ba006af57380fa48858b39f72fde6405031 Mon Sep 17 00:00:00 2001
Takashi Iwai c0b42c
From: Brian Norris <briannorris@chromium.org>
Takashi Iwai c0b42c
Date: Wed, 7 Nov 2018 12:40:29 -0800
Takashi Iwai c0b42c
Subject: [PATCH] usb: dwc3: don't log probe deferrals; but do log other error codes
Takashi Iwai c0b42c
Git-commit: 408d3ba006af57380fa48858b39f72fde6405031
Takashi Iwai c0b42c
Patch-mainline: v5.0-rc1
Takashi Iwai c0b42c
References: bsc#1051510
Takashi Iwai c0b42c
Takashi Iwai c0b42c
It's not very useful to repeat a bunch of probe deferral errors. And
Takashi Iwai c0b42c
it's also not very useful to log "failed" without telling the error
Takashi Iwai c0b42c
code.
Takashi Iwai c0b42c
Takashi Iwai c0b42c
Signed-off-by: Brian Norris <briannorris@chromium.org>
Takashi Iwai c0b42c
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Takashi Iwai c0b42c
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai c0b42c
Takashi Iwai c0b42c
---
Takashi Iwai c0b42c
 drivers/usb/dwc3/core.c | 3 ++-
Takashi Iwai c0b42c
 1 file changed, 2 insertions(+), 1 deletion(-)
Takashi Iwai c0b42c
Takashi Iwai c0b42c
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
Takashi Iwai c0b42c
index 0807353f3b07..6acadd647dc3 100644
Takashi Iwai c0b42c
--- a/drivers/usb/dwc3/core.c
Takashi Iwai c0b42c
+++ b/drivers/usb/dwc3/core.c
Takashi Iwai c0b42c
@@ -1486,7 +1486,8 @@ static int dwc3_probe(struct platform_device *pdev)
Takashi Iwai c0b42c
 
Takashi Iwai c0b42c
 	ret = dwc3_core_init(dwc);
Takashi Iwai c0b42c
 	if (ret) {
Takashi Iwai c0b42c
-		dev_err(dev, "failed to initialize core\n");
Takashi Iwai c0b42c
+		if (ret != -EPROBE_DEFER)
Takashi Iwai c0b42c
+			dev_err(dev, "failed to initialize core: %d\n", ret);
Takashi Iwai c0b42c
 		goto err4;
Takashi Iwai c0b42c
 	}
Takashi Iwai c0b42c
 
Takashi Iwai c0b42c
-- 
Takashi Iwai c0b42c
2.16.4
Takashi Iwai c0b42c